[TS migration] Migrate 'useThrottledButtonState.js' hook to TypeScript #28920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazejkustra
approved these changes
Oct 5, 2023
| * @returns {Array} | ||
| */ | ||
| export default function useThrottledButtonState() { | ||
| type ThrottledButtonState = [boolean, () => void]; |
There was a problem hiding this comment.
Suggested change
| type ThrottledButtonState = [boolean, () => void]; | |
| type ThrottledButtonState = [boolean, Dispatch<SetStateAction<boolean>>]; |
There was a problem hiding this comment.
@kubabutkiewicz when I apply your suggestion, I'm getting this tooltip:
Which is expecting a boolean value to be passed to that function. In reality though, this function doesn't accept any params. LMK your thoughts.
There was a problem hiding this comment.
ok, I thought we are returning the state setter from this hook but we are returning function which is just setting state to false so nvm. LGTM
Reviewer Checklist
Screenshots/VideosWeb01_MacOS_Chrome.mp4Mobile Web - Chrome02_Android_Chrome.mp4Mobile Web - Safari03_iOS_Safari.mp4Desktop04_MacOS_Desktop.mp4iOS05_iOS_Native.mp4Android06_Android_Native.mp4 |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24936 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
64 tasks
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.80-0 🚀
|
|
@srikarparsi Not sure we can QA at our end. Is this internal? |
|
@MaciejSWM Not sure we can QA at our end. Is this internal? |
|
@kavimuru It's used by PressableWithDelayToggle so you can test it by:
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀
|
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.81-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #24936
PROPOSAL:
Tests
shouldShowDownloadButton = false,totrueinHeaderInBackButton/index.js. This will show a Download icon in the header, e.g. when you openSend messagescreen. Click that icon. Icon should highlight and return back to normal thanks touseThrottledButtonStateafter1800ms. This will confirm that nothing breaks.Offline tests
TestsQA Steps
TestsPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-10-05.at.17.01.48.mov
Mobile Web - Chrome
Screen.Recording.2023-10-05.at.17.13.17.mov
Mobile Web - Safari
Screen.Recording.2023-10-09.at.10.39.34.mov
Desktop
Screen.Recording.2023-10-05.at.17.02.09.mov
iOS
Screen.Recording.2023-10-09.at.10.39.03.mov
Android
Screen.Recording.2023-10-05.at.17.11.18.mov