Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] [TS Migration] Migrate PaymentMethods.js to TypeScript #29074

Merged
merged 12 commits into from
Oct 18, 2023
Merged

[No QA] [TS Migration] Migrate PaymentMethods.js to TypeScript #29074

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2acb97a
export missing types
JKobrynski Oct 6, 2023
c0a69bc
migrate PaymentMethods to TypeScript
JKobrynski Oct 6, 2023
c4e692e
Merge branch 'main' into migratePaymentMethodsToTypeScript
JKobrynski Oct 9, 2023
7d30ece
add missing fields to types, fix type errors
JKobrynski Oct 9, 2023
66030eb
remove unnecessary comments, apply minor fixes
JKobrynski Oct 9, 2023
6a2dec0
extract types, fix minor issues
JKobrynski Oct 9, 2023
7369a5c
type API parameters
JKobrynski Oct 10, 2023
29e42f7
use OnyxUpdate type
JKobrynski Oct 10, 2023
a7c9065
bring back missing onyx key
JKobrynski Oct 10, 2023
439d2ec
apply suggested changes
JKobrynski Oct 12, 2023
0485702
type API data, prevent dependency cycle
JKobrynski Oct 12, 2023
9f0956a
Merge branch 'main' into migratePaymentMethodsToTypeScript
JKobrynski Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/libs/PaymentUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
import {SvgProps} from 'react-native-svg';
import BankAccountModel from './models/BankAccount';
import getBankIcon from '../components/Icon/BankIcons';
import CONST from '../CONST';
import * as Localize from './Localize';
import Fund from '../types/onyx/Fund';
import BankAccount from '../types/onyx/BankAccount';
import PaymentMethod from '../types/onyx/PaymentMethod';

type AccountType = BankAccount['accountType'] | Fund['accountType'];

type PaymentMethod = (BankAccount | Fund) & {
description: string;
icon: React.FC<SvgProps>;
iconSize?: number;
};

/**
* Check to see if user has either a debit card or personal bank account added
*/
Expand Down
356 changes: 0 additions & 356 deletions src/libs/actions/PaymentMethods.js
View file
Open in desktop

This file was deleted.

Loading
Loading