-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(28902): [FlashList migration] PaymentMethodList #29095
Changes from all commits
b5e45fc
22e6de2
0de9d9d
6f09876
188326e
44d9c4d
a1c0e24
da94edd
a660653
b9138d7
7a9e846
7ce37a6
02c6f00
c285013
3d6ad2f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -152,6 +152,7 @@ export default { | |
anonymousReportFooterBreakpoint: 650, | ||
dropDownButtonDividerHeight: 28, | ||
addPaymentMethodLeftSpacing: 2, | ||
paymentMethodHeight: 64, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adhorodyski I just realized we already had a const for this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure thing, will update in the morning! 🙂 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please see my follow up PR #30486 :) |
||
addBankAccountLeftSpacing: 3, | ||
eReceiptThumbnailSmallBreakpoint: 110, | ||
eReceiptThumbnailMediumBreakpoint: 335, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this may have caused #33075 as
variables.paymentMethodHeight
is only equal to 1 item's height, but we can have multiple cards. More details here.