Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Migrate EmojiPickerMenu Class component to Functional Component #29241

Merged
merged 48 commits into from
Oct 18, 2023
Merged

Refactor: Migrate EmojiPickerMenu Class component to Functional Component #29241

merged 48 commits into from
Oct 18, 2023

Commits on Oct 12, 2023

  1. refactor: rename index*.js to EmojiPickerMenu*.tsx 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    4bb0916 View commit details
    Browse the repository at this point in the history

  2. refactor: barrel import EmojiPickerMenu 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0385879 View commit details
    Browse the repository at this point in the history

  3. progress Expensify#1: convert class to function + add function keywor… 

    …d to class methods

Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5fcc5cc View commit details
    Browse the repository at this point in the history

  4. progress Expensify#2: props 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5716e80 View commit details
    Browse the repository at this point in the history

  5. progress Expensify#3: searchInputRef -> searchInputRef 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    52eb14c View commit details
    Browse the repository at this point in the history

  6. progress Expensify#4: emojiList -> emojiListRef 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7959d01 View commit details
    Browse the repository at this point in the history

  7. progress Expensify#5: filterEmojis() with useCallback + shouldFocusIn… 

    …putOnScreenFocus

Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    9354019 View commit details
    Browse the repository at this point in the history

  8. progress Expensify#6: highlightAdjacentEmoji() + setupEventHandlers()… 

    … + cleanupEventHandlers()

Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    65fdee9 View commit details
    Browse the repository at this point in the history

  9. progress Expensify#7: renderItem() +onSelectionChange() 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    35726f6 View commit details
    Browse the repository at this point in the history

  10. progress Expensify#8:updatePreferredSkinTone() + JsDoc upd in User.js 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    2ba2e82 View commit details
    Browse the repository at this point in the history

  11. progress Expensify#9:setFirstNonHeaderIndex() + getItemLayout() + scr… 

    …ollToHeader()

Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3aa5cfb View commit details
    Browse the repository at this point in the history

  12. p#10: rename setFirstNonHeaderIndex -> updateFirstNonHeaderIndex() + … 

    …firstNonHeaderIndex converted to ref

Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    607b0cb View commit details
    Browse the repository at this point in the history

  13. p#11: emojis Ref + filteredEmojis state 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c071646 View commit details
    Browse the repository at this point in the history

  14. p#12: headerRowIndices Ref + headerIndices state 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    878f663 View commit details
    Browse the repository at this point in the history

  15. p#13: headerEmojis ref (IMP!!: this should be a ref) 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    cbd0dc4 View commit details
    Browse the repository at this point in the history

  16. p#14: highlightedIndex state 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    4a7995e View commit details
    Browse the repository at this point in the history

  17. p#15: arePointerEventsDisabled state 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5634ec4 View commit details
    Browse the repository at this point in the history

  18. p#16: selection state 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5c7d459 View commit details
    Browse the repository at this point in the history

  19. p#17: isFocused state 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    76bde46 View commit details
    Browse the repository at this point in the history

  20. p#17: isUsingKeyboardMovement state 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7ee44e4 View commit details
    Browse the repository at this point in the history

  21. p#18: convert missed this.state.filteredEmojis 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    d95a5ec View commit details
    Browse the repository at this point in the history

  22. p#19: selectTextOnFocus state 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    76b0fa9 View commit details
    Browse the repository at this point in the history

  23. p#20: keyDownHandler() + keyExtractor() 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c8fab62 View commit details
    Browse the repository at this point in the history

  24. p#20: mouseMoveHandler() 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    4ddcfaa View commit details
    Browse the repository at this point in the history

  25. p#21: focusInputWithTextSelect() + addToFrequentAndSelectEmoji() 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c684aee View commit details
    Browse the repository at this point in the history

  26. p#21: cleanup 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    24c9681 View commit details
    Browse the repository at this point in the history

  27. p#22: lifecycle methods: componentDidMount + componentWillUnmount 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8e2540f View commit details
    Browse the repository at this point in the history

  28. p#22: lifecycle method: componentDidUpdate() 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    57ac93b View commit details
    Browse the repository at this point in the history

  29. p#23: cleanup: rename class component file as old.EmojiPickerMenu.tsx 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    60483ea View commit details
    Browse the repository at this point in the history

  30. fix: all emojis not visible 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1a0cc8e View commit details
    Browse the repository at this point in the history

  31. rename EmojiPickerMenu copy to EmojiPickerMenu 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    58bec01 View commit details
    Browse the repository at this point in the history

  32. fix: remove TS types 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    5ee4b64 View commit details
    Browse the repository at this point in the history

  33. remove TODO comments 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    94022aa View commit details
    Browse the repository at this point in the history

  34. rename all .ts* back to .js* 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7f80407 View commit details
    Browse the repository at this point in the history

  35. delete old class component 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c9e1762 View commit details
    Browse the repository at this point in the history

  36. fix: fix Bad Practice. headerEmoji (ref) was being read during render 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e102c5e View commit details
    Browse the repository at this point in the history

  37. remove index.js 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3f70fb4 View commit details
    Browse the repository at this point in the history

  38. rename: EmojiPickerMenu*.jsx -> index*.js 

    Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    25f7ba6 View commit details
    Browse the repository at this point in the history

  39. Merge branch 'main' of github.com:Expensify/App into refactor/emojipi… 

    …ckermenu-try2
    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0c88110 View commit details
    Browse the repository at this point in the history

  40. fix: eslint error: "ES2020 optional chaining is forbidden"

    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    bcffdbe View commit details
    Browse the repository at this point in the history

  41. fix: eslint error: "JSX props should not use functions"

    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7e999a6 View commit details
    Browse the repository at this point in the history

  42. fix: eslint error: useCallback & useEffect deps array

    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0c9c6d2 View commit details
    Browse the repository at this point in the history

  43. fix: eslint error: usused variable error

    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3ccc9a8 View commit details
    Browse the repository at this point in the history

  44. fix: eslint "warnings" about useCallback & useEffect deps arr

    @ashuvssut
    ashuvssut committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1c0320a View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. fix: emoji filter not working

    @ashuvssut
    ashuvssut committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    7098e80 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge branch 'main' of github.com:Expensify/App into refactor/emojipi… 

    …ckermenu-try2
    @ashuvssut
    ashuvssut committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    d7e3939 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. fix: eslint warn -- extra deps in useCallaback

    @ashuvssut
    ashuvssut committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    66b4969 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Merge branch 'refactor/emojipickermenu-try2' of github.com:ashuvssut/… 

    …expensify-app; branch 'main' of github.com:Expensify/App into refactor/emojipickermenu-try2
    @ashuvssut
    ashuvssut committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    f17add9 View commit details
    Browse the repository at this point in the history