-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Migrate EmojiPickerMenu Class component to Functional Component #29241
Refactor: Migrate EmojiPickerMenu Class component to Functional Component #29241
Commits on Oct 12, 2023
-
refactor: rename index*.js to EmojiPickerMenu*.tsx
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4bb0916 - Browse repository at this point
Copy the full SHA 4bb0916View commit details -
refactor: barrel import EmojiPickerMenu
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0385879 - Browse repository at this point
Copy the full SHA 0385879View commit details -
progress Expensify#1: convert class to function + add function keywor…
…d to class methods Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5fcc5cc - Browse repository at this point
Copy the full SHA 5fcc5ccView commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5716e80 - Browse repository at this point
Copy the full SHA 5716e80View commit details -
progress Expensify#3: searchInputRef -> searchInputRef
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 52eb14c - Browse repository at this point
Copy the full SHA 52eb14cView commit details -
progress Expensify#4: emojiList -> emojiListRef
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7959d01 - Browse repository at this point
Copy the full SHA 7959d01View commit details -
progress Expensify#5: filterEmojis() with useCallback + shouldFocusIn…
…putOnScreenFocus Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9354019 - Browse repository at this point
Copy the full SHA 9354019View commit details -
progress Expensify#6: highlightAdjacentEmoji() + setupEventHandlers()…
… + cleanupEventHandlers() Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 65fdee9 - Browse repository at this point
Copy the full SHA 65fdee9View commit details -
progress Expensify#7: renderItem() +onSelectionChange()
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 35726f6 - Browse repository at this point
Copy the full SHA 35726f6View commit details -
progress Expensify#8:updatePreferredSkinTone() + JsDoc upd in User.js
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2ba2e82 - Browse repository at this point
Copy the full SHA 2ba2e82View commit details -
progress Expensify#9:setFirstNonHeaderIndex() + getItemLayout() + scr…
…ollToHeader() Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3aa5cfb - Browse repository at this point
Copy the full SHA 3aa5cfbView commit details -
p#10: rename setFirstNonHeaderIndex -> updateFirstNonHeaderIndex() + …
…firstNonHeaderIndex converted to ref Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 607b0cb - Browse repository at this point
Copy the full SHA 607b0cbView commit details -
p#11: emojis Ref + filteredEmojis state
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c071646 - Browse repository at this point
Copy the full SHA c071646View commit details -
p#12: headerRowIndices Ref + headerIndices state
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 878f663 - Browse repository at this point
Copy the full SHA 878f663View commit details -
p#13: headerEmojis ref (IMP!!: this should be a ref)
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cbd0dc4 - Browse repository at this point
Copy the full SHA cbd0dc4View commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4a7995e - Browse repository at this point
Copy the full SHA 4a7995eView commit details -
p#15: arePointerEventsDisabled state
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5634ec4 - Browse repository at this point
Copy the full SHA 5634ec4View commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5c7d459 - Browse repository at this point
Copy the full SHA 5c7d459View commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 76bde46 - Browse repository at this point
Copy the full SHA 76bde46View commit details -
p#17: isUsingKeyboardMovement state
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7ee44e4 - Browse repository at this point
Copy the full SHA 7ee44e4View commit details -
p#18: convert missed this.state.filteredEmojis
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d95a5ec - Browse repository at this point
Copy the full SHA d95a5ecView commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 76b0fa9 - Browse repository at this point
Copy the full SHA 76b0fa9View commit details -
p#20: keyDownHandler() + keyExtractor()
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c8fab62 - Browse repository at this point
Copy the full SHA c8fab62View commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4ddcfaa - Browse repository at this point
Copy the full SHA 4ddcfaaView commit details -
p#21: focusInputWithTextSelect() + addToFrequentAndSelectEmoji()
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c684aee - Browse repository at this point
Copy the full SHA c684aeeView commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 24c9681 - Browse repository at this point
Copy the full SHA 24c9681View commit details -
p#22: lifecycle methods: componentDidMount + componentWillUnmount
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8e2540f - Browse repository at this point
Copy the full SHA 8e2540fView commit details -
p#22: lifecycle method: componentDidUpdate()
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 57ac93b - Browse repository at this point
Copy the full SHA 57ac93bView commit details -
p#23: cleanup: rename class component file as old.EmojiPickerMenu.tsx
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 60483ea - Browse repository at this point
Copy the full SHA 60483eaView commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a0cc8e - Browse repository at this point
Copy the full SHA 1a0cc8eView commit details -
rename EmojiPickerMenu copy to EmojiPickerMenu
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 58bec01 - Browse repository at this point
Copy the full SHA 58bec01View commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5ee4b64 - Browse repository at this point
Copy the full SHA 5ee4b64View commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 94022aa - Browse repository at this point
Copy the full SHA 94022aaView commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7f80407 - Browse repository at this point
Copy the full SHA 7f80407View commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c9e1762 - Browse repository at this point
Copy the full SHA c9e1762View commit details -
fix: fix Bad Practice. headerEmoji (ref) was being read during render
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e102c5e - Browse repository at this point
Copy the full SHA e102c5eView commit details -
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3f70fb4 - Browse repository at this point
Copy the full SHA 3f70fb4View commit details -
rename: EmojiPickerMenu*.jsx -> index*.js
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 25f7ba6 - Browse repository at this point
Copy the full SHA 25f7ba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c88110 - Browse repository at this point
Copy the full SHA 0c88110View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcffdbe - Browse repository at this point
Copy the full SHA bcffdbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e999a6 - Browse repository at this point
Copy the full SHA 7e999a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c9c6d2 - Browse repository at this point
Copy the full SHA 0c9c6d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ccc9a8 - Browse repository at this point
Copy the full SHA 3ccc9a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c0320a - Browse repository at this point
Copy the full SHA 1c0320aView commit details
Commits on Oct 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7098e80 - Browse repository at this point
Copy the full SHA 7098e80View commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d7e3939 - Browse repository at this point
Copy the full SHA d7e3939View commit details
Commits on Oct 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 66b4969 - Browse repository at this point
Copy the full SHA 66b4969View commit details
Commits on Oct 18, 2023
-
Merge branch 'refactor/emojipickermenu-try2' of github.com:ashuvssut/…
…expensify-app; branch 'main' of github.com:Expensify/App into refactor/emojipickermenu-try2
Configuration menu - View commit details
-
Copy full SHA for f17add9 - Browse repository at this point
Copy the full SHA f17add9View commit details