-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/28952: Add subtitle to category page #29266
Conversation
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@Santhosh-Sellavel is the C+ on this one. Sorry for the confusion @aimane-chnaif |
@Santhosh-Sellavel Could you help to review this PR when you have a chance? Thanks so much |
@puneetlath Can you ask someone to verify es copies |
I think it's fine since it's exactly like the tag copy. |
Steps to test tag is unclear, can you add clear steps please. |
@Santhosh-Sellavel App/src/pages/EditRequestPage.js Line 136 in 5b35a3c
Update Screen.Recording.2023-10-13.at.11.07.14.mov |
@Santhosh-Sellavel Bump, could you help to check my comment ? |
Have you gone through Puneeth's comment #28952 (comment)? |
@Santhosh-Sellavel Unfortunately, I can't reproduce like that |
Reviewer Checklist
Screenshots/Videos |
@Santhosh-Sellavel Bump, could you help to finish the checklist? |
@Santhosh-Sellavel Bump, Any update here? |
Sorry, I'm not sure what went wrong I remember completing the checklist. Revisit this one again today! |
@DylanDylann Update the QA steps
This would be confusing for QA, so please update to
cc: @puneetlath this should be good right? |
Yeah that sounds good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#29266 (comment) should be addressed otherwise Looks good to me!
@DylanDylann Looking at Steps once again, it can be improved. The actual Steps Suggested by Puneet here work well for me! So please update the QA Steps as follows!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.88-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀
|
@@ -562,6 +562,7 @@ export default { | |||
threadRequestReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} request${comment ? ` for ${comment}` : ''}`, | |||
threadSentMoneyReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} sent${comment ? ` for ${comment}` : ''}`, | |||
tagSelection: ({tagName}: TagSelectionParams) => `Select a ${tagName} to add additional organization to your money`, | |||
categorySelection: 'Select a category to add additional organization to your money', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this copy was checked? It does not really read like a proper English sentence. We're going to create an issue to modify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here: #38242
Details
Add subtitle to category page
Fixed Issues
$ #28952
PROPOSAL: #28952 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop