Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] [TS migration] Migrate 'TestTool.js' lib to TypeScript #29364

Merged
merged 4 commits into from
Oct 19, 2023
Merged

[No QA] [TS migration] Migrate 'TestTool.js' lib to TypeScript #29364

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92a81a8
Init migration
BartoszGrajdek Sep 17, 2023
56bf6f5
Merge remote-tracking branch 'origin/main' into ts-migration/test-too…
BartoszGrajdek Oct 11, 2023
3096370
Add throttle
BartoszGrajdek Oct 11, 2023
7d44005
Merge remote-tracking branch 'origin/main' into ts-migration/test-too…
BartoszGrajdek Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libs/actions/TestTool.js → src/libs/actions/TestTool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import throttle from 'lodash/throttle';
import Onyx from 'react-native-onyx';
import _ from 'underscore';
import ONYXKEYS from '../../ONYXKEYS';
import CONST from '../../CONST';

let isTestToolsModalOpen = false;
Onyx.connect({
key: ONYXKEYS.IS_TEST_TOOLS_MODAL_OPEN,
callback: (val) => (isTestToolsModalOpen = val || false),
callback: (val) => (isTestToolsModalOpen = val ?? false),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: maybe change it to value

});

/**
Expand All @@ -15,7 +15,7 @@ Onyx.connect({
*/
function toggleTestToolsModal() {
const toggle = () => Onyx.set(ONYXKEYS.IS_TEST_TOOLS_MODAL_OPEN, !isTestToolsModalOpen);
const throttledToggle = _.throttle(toggle, CONST.TIMING.TEST_TOOLS_MODAL_THROTTLE_TIME);
const throttledToggle = throttle(toggle, CONST.TIMING.TEST_TOOLS_MODAL_THROTTLE_TIME);
throttledToggle();
}

Expand Down
Loading