-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] [TS migration] Migrate 'withViewportOffsetTop.js' HOC to TypeScript #29546
[No QA] [TS migration] Migrate 'withViewportOffsetTop.js' HOC to TypeScript #29546
Conversation
684054c
to
d7f183c
Compare
d7f183c
to
122717f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
122717f
to
d2dbcbe
Compare
d2dbcbe
to
84e9ff9
Compare
Reviewer Checklist
Screenshots/VideosWeb29546-web.mp4Mobile Web - Chrome29546-mobile-chrome.mp4Mobile Web - Safari29546-mobile-safari.mp4Desktop29546-desktop.mp4iOS29546-mobile-ios.mp4Android29546-mobile-android.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Additionally, @pasyukevich, could you please fix the links in the screenshot for preview?
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24958 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
@ntdiary screenshots fixed |
@blazejkustra @ntdiary are you happy with the changes? I'll review once you are. |
|
||
useEffect(() => { | ||
const updateDimensions = (event: Event) => { | ||
const targetOffsetTop = (event.target instanceof HTMLElement && event.target.offsetTop) || 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pasyukevich You should be able to use instanceof VisualViewport
or other option is to get back to assertion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puneetlath, only this one #29546 (comment), There are no other problems. : ) |
I tested it, it's indeed |
@puneetlath, all yours. : ) |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.88-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀
|
Details
Fixed Issues
$ #24958
PROPOSAL:
Tests
:smile:
, etc)Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web-desktop.mp4
MacOS: Desktop