-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow assigning task to new accounts #29730
Conversation
Screen.Recording.2023-12-22.at.7.43.22.AM.mov
Screen.Recording.2023-12-22.at.7.31.08.AM.mov
|
Yup, that is correct - I think I had a weird issue in my chrome video
This is not intended, I updated the method to make sure this behavior does not happen
Not intended but outside the scope of this issue |
Reviewer Checklist
Screenshots/VideosAndroid: NativeassignTaskAndroidNative.mp4Android: mWeb ChromeassignTask.mp4iOS: NativeScreen.Recording.2023-12-23.at.9.57.54.AM.moviOS: mWeb SafariScreen.Recording.2023-12-23.at.10.42.41.AM.movMacOS: Chrome / SafariAssigning new userScreen.Recording.2023-12-23.at.12.23.35.AM.movNavigating to parent report Screen.Recording.2023-12-23.at.12.24.31.AM.movMacOS: DesktopScreen.Recording.2023-12-23.at.12.27.51.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No, if there are only change logs it should delete the task. However, the only system messages that should be able to exist in a task are related to task system messages |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.22-0 🚀
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.22-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.22-6 🚀
|
Delete task is destructive we missed to get a confirmation before delete, we handled it here |
Details
Changes made in this PR
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/311912
$ #33236
PROPOSAL:
Tests
Same as QA steps
Offline tests
Same as online
QA Steps
Assigning new user
Navigation
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
My IOS / Android simulators are not working so will have to have the C+ test those - but these changes are not platform specific by any meansAndroid: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Screen.Recording.2023-12-21.at.2.28.29.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2023-12-21.at.2.27.12.PM.mov
MacOS: Desktop
Screen.Recording.2023-12-21.at.2.33.52.PM.mov