Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto submit magic code during first submit only #29731

Merged
merged 5 commits into from
Oct 17, 2023
Merged

auto submit magic code during first submit only #29731

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
055722b
auto submit magic code during first submit only
saranshbalyan-1234 Oct 8, 2023
6bfd5d7
Update MagicCodeInput.js
saranshbalyan-1234 Oct 17, 2023
2efad79
Merge pull request #1 from saranshbalyan-1234/main
saranshbalyan-1234 Oct 17, 2023
bc7de34
Update MagicCodeInput.js
saranshbalyan-1234 Oct 17, 2023
3651dfd
Update MagicCodeInput.js
saranshbalyan-1234 Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/MagicCodeInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ function MagicCodeInput(props) {
const [input, setInput] = useState('');
const [focusedIndex, setFocusedIndex] = useState(0);
const [editIndex, setEditIndex] = useState(0);
const [wasSubmitted, setWasSubmitted] = useState(false);

const blurMagicCodeInput = () => {
inputRefs.current[editIndex].blur();
Expand All @@ -124,9 +125,12 @@ function MagicCodeInput(props) {

const validateAndSubmit = () => {
const numbers = decomposeString(props.value, props.maxLength);
if (!props.shouldSubmitOnComplete || _.filter(numbers, (n) => ValidationUtils.isNumeric(n)).length !== props.maxLength || props.network.isOffline) {
if (wasSubmitted || !props.shouldSubmitOnComplete || _.filter(numbers, (n) => ValidationUtils.isNumeric(n)).length !== props.maxLength || props.network.isOffline) {
return;
}
if (!wasSubmitted) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, wasSubmitted is always false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a minor thing (as it might be argued that the explicit if adds some readability), I'll still approve. But I would personally remove the if.

setWasSubmitted(true);
}
// Blurs the input and removes focus from the last input and, if it should submit
// on complete, it will call the onFulfill callback.
blurMagicCodeInput();
Expand Down
Loading