Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form Provider Refactor] RoomNameInput #29771
[Form Provider Refactor] RoomNameInput #29771
Changes from 15 commits
5248bc6
5b4a419
bd87379
10ea700
eab18e6
40a6da2
e35bddc
2e12b63
1fd92cc
ba1a78d
fefdb2b
e05b537
eff3e88
187fa7d
398b842
edd40b9
bd686b2
d68434e
a37be42
6edeecf
f0b7aea
565ea7c
19077c1
ccf0b9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer an issue with the new solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, with current approach if we are parsing the value of the input, it's completely separated from the value we display, so it's faster (we are limiting numbers of re-renders) and it doesn't affect the cursor.
This file was deleted.