Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow receipt recovery if the upload fails #29790
Allow receipt recovery if the upload fails #29790
Changes from all commits
4fa79fd
418f5d7
ccda700
ee3fbdb
6cb7230
8749857
52f5e50
d97beb3
ca1443a
0c559d1
08d8e86
040c5ed
c43ff48
17a1c43
1d95f46
0d010f9
7867ece
b1d6295
42e4ba3
8b0382b
5529aae
f8ce4eb
97e94ae
3dc3512
04b4563
b1e1d13
467fcc3
a87aac4
b308067
de455c3
9bf109c
24a1a76
cc15c6d
b3a6ca9
70d2432
bb41f23
e134818
57f1a8d
4366cd8
7021a01
d52631c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gonals I'm working on
DotIndicatorMessage
TS migration PR and while resolving conflicts I noticed this logic change:👇 With these lines
sortedMessages
is an array of strings, so I don't see howisReceiptError
will ever return true for the code above, therefore the whole logic withPressableWithoutFeedback
is unnecessary in my opinion 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to follow the steps from the description but I get a different error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah actually it works but it is kind of hacky 😅
ReceiptError
object is passed to this function as a 'message', the error is thrown inside try block but it is caught in the catch block and the whole object is returned instead of astring
as function signature suggests. I think it would makes things more readable if we were to change the logic here/or use a different component for Receipt errors. cc @Gonals @nkuoch @0xmiroslavThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from this issue #39330, we should use either
Pressable
component orTextLink
here, instead of wrapping the whole text inside aPressable
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gonals The error text next to red dot indicators is meant to be red to be consistent with other error messages in the app.
With your current change here, the error text will revert back to light-greyish green.
I just worked on an issue fixing this and just luckily stumbled on the regression from the video of another issue I was looking at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this word "Guarda" to "Download" as well for consistency.
cc: @marcochavezf for Spanish help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm from Spain! I decided to leave both as they are on purpose 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: I think it sounds a bit better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating above, please also apply this suggestion 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using "archivo" twice in a row doesn't quite work: "Guarda el archivo o descarta este error y pierde el archivo" is a bit redundant