[Form Provider Refactor] AddDebitCardPage #29983
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import lodashGet from 'lodash/get'; | ||
| import PropTypes from 'prop-types'; | ||
| import React, {useCallback, useEffect, useMemo, useRef, useState} from 'react'; | ||
| import {ActivityIndicator, Keyboard, LogBox, ScrollView, Text, View} from 'react-native'; | ||
| import {GooglePlacesAutocomplete} from 'react-native-google-places-autocomplete'; | ||
| import _ from 'underscore'; | ||
|
|
@@ -140,27 +140,46 @@ const defaultProps = { | |
| resultTypes: 'address', | ||
| }; | ||
|
|
||
| function AddressSearch({ | ||
| canUseCurrentLocation, | ||
| containerStyles, | ||
| defaultValue, | ||
| errorText, | ||
| hint, | ||
| innerRef, | ||
| inputID, | ||
| isLimitedToUSA, | ||
| label, | ||
| maxInputLength, | ||
| network, | ||
| onBlur, | ||
| onInputChange, | ||
| onPress, | ||
| predefinedPlaces, | ||
| preferredLocale, | ||
| renamedInputKeys, | ||
| resultTypes, | ||
| shouldSaveDraft, | ||
| translate, | ||
| value, | ||
| }) { | ||
| const [displayListViewBorder, setDisplayListViewBorder] = useState(false); | ||
| const [isTyping, setIsTyping] = useState(false); | ||
| const [isFocused, setIsFocused] = useState(false); | ||
| const [searchValue, setSearchValue] = useState(value || defaultValue || ''); | ||
| const [locationErrorCode, setLocationErrorCode] = useState(null); | ||
| const [isFetchingCurrentLocation, setIsFetchingCurrentLocation] = useState(false); | ||
| const shouldTriggerGeolocationCallbacks = useRef(true); | ||
| const containerRef = useRef(); | ||
| const query = useMemo( | ||
| () => ({ | ||
| language: preferredLocale, | ||
| types: resultTypes, | ||
| components: isLimitedToUSA ? 'country:us' : undefined, | ||
| }), | ||
| [preferredLocale, resultTypes, isLimitedToUSA], | ||
| ); | ||
| const shouldShowCurrentLocationButton = canUseCurrentLocation && searchValue.trim().length === 0 && isFocused; | ||
|
|
||
| const saveLocationDetails = (autocompleteData, details) => { | ||
| const addressComponents = details.address_components; | ||
|
|
@@ -169,7 +188,7 @@ function AddressSearch(props) { | |
| // to this component which don't match the usual properties coming from auto-complete. In that case, only a limited | ||
| // amount of data massaging needs to happen for what the parent expects to get from this function. | ||
| if (_.size(details)) { | ||
| onPress({ | ||
| address: lodashGet(details, 'description'), | ||
| lat: lodashGet(details, 'geometry.location.lat', 0), | ||
| lng: lodashGet(details, 'geometry.location.lng', 0), | ||
|
|
@@ -256,7 +275,7 @@ function AddressSearch(props) { | |
|
|
||
| // Not all pages define the Address Line 2 field, so in that case we append any additional address details | ||
| // (e.g. Apt #) to Address Line 1 | ||
| if (subpremise && typeof renamedInputKeys.street2 === 'undefined') { | ||
| values.street += `, ${subpremise}`; | ||
| } | ||
|
|
||
|
|
@@ -265,19 +284,19 @@ function AddressSearch(props) { | |
| values.country = country; | ||
| } | ||
|
|
||
| if (inputID) { | ||
| _.each(values, (inputValue, key) => { | ||
| const inputKey = lodashGet(renamedInputKeys, key, key); | ||
| if (!inputKey) { | ||
| return; | ||
| } | ||
| onInputChange(inputValue, inputKey); | ||
| }); | ||
| } else { | ||
| onInputChange(values); | ||
| } | ||
|
|
||
| onPress(values); | ||
| }; | ||
|
|
||
| /** Gets the user's current location and registers success/error callbacks */ | ||
|
|
@@ -307,7 +326,7 @@ function AddressSearch(props) { | |
| lng: successData.coords.longitude, | ||
| address: CONST.YOUR_LOCATION_TEXT, | ||
| }; | ||
| onPress(location); | ||
| }, | ||
| (errorData) => { | ||
| if (!shouldTriggerGeolocationCallbacks.current) { | ||
|
|
@@ -325,16 +344,16 @@ function AddressSearch(props) { | |
| }; | ||
|
|
||
| const renderHeaderComponent = () => | ||
| predefinedPlaces.length > 0 && ( | ||
| <> | ||
| {/* This will show current location button in list if there are some recent destinations */} | ||
| {shouldShowCurrentLocationButton && ( | ||
| <CurrentLocationButton | ||
| onPress={getCurrentLocation} | ||
| isDisabled={network.isOffline} | ||
| /> | ||
| )} | ||
| {!value && <Text style={[styles.textLabel, styles.colorMuted, styles.pv2, styles.ph3, styles.overflowAuto]}>{translate('common.recentDestinations')}</Text>} | ||
| </> | ||
| ); | ||
|
|
||
|
|
@@ -346,6 +365,26 @@ function AddressSearch(props) { | |
| }; | ||
| }, []); | ||
|
|
||
| const listEmptyComponent = useCallback( | ||
|
There was a problem hiding this comment. I think we can use There was a problem hiding this comment. I think the function is best suited for a child to be used as a functional component. Otherwise, the react lifecycle will not work properly and the prop used inside There was a problem hiding this comment. @luacmartins I think I think it's safer to use callback and the value of the prop needs to be a function. |
||
| () => | ||
| network.isOffline || !isTyping ? null : ( | ||
| <Text style={[styles.textLabel, styles.colorMuted, styles.pv4, styles.ph3, styles.overflowAuto]}>{translate('common.noResultsFound')}</Text> | ||
| ), | ||
| [isTyping, translate, network.isOffline], | ||
| ); | ||
|
|
||
| const listLoader = useCallback( | ||
kowczarz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| () => ( | ||
| <View style={[styles.pv4]}> | ||
| <ActivityIndicator | ||
| color={themeColors.spinner} | ||
| size="small" | ||
| /> | ||
| </View> | ||
| ), | ||
| [], | ||
| ); | ||
|
|
||
| return ( | ||
| /* | ||
| * The GooglePlacesAutocomplete component uses a VirtualizedList internally, | ||
|
|
@@ -372,20 +411,10 @@ function AddressSearch(props) { | |
| fetchDetails | ||
| suppressDefaultStyles | ||
| enablePoweredByContainer={false} | ||
| predefinedPlaces={predefinedPlaces} | ||
| listEmptyComponent={listEmptyComponent} | ||
| listLoaderComponent={listLoader} | ||
| renderHeaderComponent={renderHeaderComponent} | ||
| renderRow={(data) => { | ||
| const title = data.isPredefinedPlace ? data.name : data.structured_formatting.main_text; | ||
| const subtitle = data.isPredefinedPlace ? data.description : data.structured_formatting.secondary_text; | ||
|
|
@@ -396,7 +425,6 @@ function AddressSearch(props) { | |
| </View> | ||
| ); | ||
| }} | ||
| onPress={(data, details) => { | ||
| saveLocationDetails(data, details); | ||
| setIsTyping(false); | ||
|
|
@@ -411,34 +439,31 @@ function AddressSearch(props) { | |
| query={query} | ||
| requestUrl={{ | ||
| useOnPlatform: 'all', | ||
| url: network.isOffline ? null : ApiUtils.getCommandURL({command: 'Proxy_GooglePlaces&proxyUrl='}), | ||
| }} | ||
| textInputProps={{ | ||
| InputComp: TextInput, | ||
| ref: (node) => { | ||
| if (!innerRef) { | ||
| return; | ||
| } | ||
|
|
||
| if (_.isFunction(innerRef)) { | ||
| innerRef(node); | ||
| return; | ||
| } | ||
|
|
||
| // eslint-disable-next-line no-param-reassign | ||
| innerRef.current = node; | ||
| }, | ||
| label, | ||
| containerStyles, | ||
| errorText, | ||
| hint: displayListViewBorder || (predefinedPlaces.length === 0 && shouldShowCurrentLocationButton) || (canUseCurrentLocation && isTyping) ? undefined : hint, | ||
| value, | ||
| defaultValue, | ||
| inputID, | ||
| shouldSaveDraft, | ||
| onFocus: () => { | ||
| setIsFocused(true); | ||
| }, | ||
|
|
@@ -448,24 +473,24 @@ function AddressSearch(props) { | |
| setIsFocused(false); | ||
| setIsTyping(false); | ||
| } | ||
| onBlur(); | ||
| }, | ||
| autoComplete: 'off', | ||
| onInputChange: (text) => { | ||
| setSearchValue(text); | ||
| setIsTyping(true); | ||
| if (inputID) { | ||
| onInputChange(text); | ||
| } else { | ||
| onInputChange({street: text}); | ||
| } | ||
|
|
||
| // If the text is empty and we have no predefined places, we set displayListViewBorder to false to prevent UI flickering | ||
| if (_.isEmpty(text) && _.isEmpty(predefinedPlaces)) { | ||
| setDisplayListViewBorder(false); | ||
| } | ||
| }, | ||
| maxLength: maxInputLength, | ||
| spellCheck: false, | ||
| }} | ||
| styles={{ | ||
|
|
@@ -486,17 +511,18 @@ function AddressSearch(props) { | |
| }} | ||
| inbetweenCompo={ | ||
| // We want to show the current location button even if there are no recent destinations | ||
| predefinedPlaces.length === 0 && shouldShowCurrentLocationButton ? ( | ||
| <View style={[StyleUtils.getGoogleListViewStyle(true), styles.overflowAuto, styles.borderLeft, styles.borderRight]}> | ||
| <CurrentLocationButton | ||
| onPress={getCurrentLocation} | ||
| isDisabled={network.isOffline} | ||
| /> | ||
| </View> | ||
| ) : ( | ||
| <></> | ||
| ) | ||
| } | ||
| placeholder="" | ||
kowczarz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| /> | ||
| <LocationErrorMessage | ||
| onClose={() => setLocationErrorCode(null)} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to spread props to avoid disabling eslint exhaustive-deps rule in line 372.