-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable auto-correct in task title input #31059
Conversation
c6ef8be
to
4ede225
Compare
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -109,6 +109,7 @@ function NewTaskDetailsPage(props) { | |||
accessibilityLabel={props.translate('task.title')} | |||
value={taskTitle} | |||
onValueChange={(value) => setTaskTitle(value)} | |||
autoCorrect={false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasperhuangg I couldn't understand from your last comment here if we're disabling for all the platforms? I think we shouldn't.
cc - @dukenv0307
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick bump @jasperhuangg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep with disabling with all platforms if we have the same behavior elsewhere in the App
sorry was OOO
Reviewer Checklist
Screenshots/VideosAndroid: Nativehttps://github.com/Expensify/App/assets/3069065/eb31a0a2-8819-48ce-b7ca-62d4ac04e917Android: mWeb Chromemweb-chrome-task-autocorrect.moviOS: Nativeios-task-autocorrect.moviOS: mWeb Safarimweb-safari-task-autocorrect.movMacOS: Chrome / Safariweb-task-autocorrect.movMacOS: Desktopdesktop-task-autocorrect.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.7-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.7-4 🚀
|
Details
Fixed Issues
$ #30870
PROPOSAL: #30870 (comment)
Tests
Next
buttonBack
button in headerOffline tests
Same as above
QA Steps
Next
buttonBack
button in headerPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2023-11-21.at.15.34.11.mov
Android: mWeb Chrome
Screen.Recording.2023-11-21.at.15.28.58.mov
iOS: Native
Screen.Recording.2023-11-21.at.15.32.09.mov
iOS: mWeb Safari
Screen.Recording.2023-11-21.at.15.30.45.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-21.at.15.27.40.mov
MacOS: Desktop
Screen.Recording.2023-11-21.at.15.35.32.mov