Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'TextInput' component to TypeScript #31356

Merged
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
326e443
ref: migrating TextInput to TS
kubabutkiewicz Nov 15, 2023
61fd846
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Nov 15, 2023
255058f
fix: fixing types problems in BaseTextInput for Web
kubabutkiewicz Nov 15, 2023
0e5fe98
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Nov 16, 2023
b573de9
fix: move inputProps const into native ones
kubabutkiewicz Nov 16, 2023
b568d32
fix: destructure props
kubabutkiewicz Nov 16, 2023
e90c503
fix: fixing types
kubabutkiewicz Nov 17, 2023
6a3a270
fix: resolving types issues
kubabutkiewicz Nov 17, 2023
aaaeac0
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 1, 2023
5b562b7
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 4, 2023
bddaeb2
fix: types
kubabutkiewicz Dec 4, 2023
2bcc1c7
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 5, 2023
4bc71cd
fix: removed commented code
kubabutkiewicz Dec 5, 2023
bbe0c5d
fix: resolve comments
kubabutkiewicz Dec 5, 2023
1f5cac7
fix: address comments
kubabutkiewicz Dec 6, 2023
fc794e3
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 7, 2023
052610c
fix: resolve comments
kubabutkiewicz Dec 7, 2023
0b22b3b
fix: lint error
kubabutkiewicz Dec 7, 2023
cd39877
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 7, 2023
c8fa81e
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 11, 2023
12f6197
fix: types
kubabutkiewicz Dec 11, 2023
b48cee2
fix: bring back proptypes as they are used in different file
kubabutkiewicz Dec 11, 2023
f327d28
fix: tests
kubabutkiewicz Dec 11, 2023
b4597cb
fix: import types
kubabutkiewicz Dec 11, 2023
3abace7
fix: import types
kubabutkiewicz Dec 11, 2023
11bf2ef
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 12, 2023
cba69d0
fix: resolve comments
kubabutkiewicz Dec 12, 2023
886aa60
fix: resolved comments
kubabutkiewicz Dec 12, 2023
ac1564e
fix: fixed default values for props
kubabutkiewicz Dec 13, 2023
e596427
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 13, 2023
d69e087
fix: adress comments
kubabutkiewicz Dec 13, 2023
aad9c1d
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 14, 2023
fa251df
fix: typecheck
kubabutkiewicz Dec 14, 2023
648100c
fix: address comments
kubabutkiewicz Dec 15, 2023
ccd8f60
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 18, 2023
31ad5b6
fix: issue with not expanding multiline textinput
kubabutkiewicz Dec 18, 2023
ee63669
fix: type issue
kubabutkiewicz Dec 18, 2023
c02470c
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 19, 2023
b6ba4e1
fix: error message color
kubabutkiewicz Dec 19, 2023
2632af4
Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…
kubabutkiewicz Dec 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Checkbox.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {ForwardedRef, forwardRef, KeyboardEvent as ReactKeyboardEvent} from 'react';
import React, {type ForwardedRef, forwardRef, type MouseEventHandler, type KeyboardEvent as ReactKeyboardEvent} from 'react';
import {GestureResponderEvent, StyleProp, View, ViewStyle} from 'react-native';
import * as StyleUtils from '@styles/StyleUtils';
import useTheme from '@styles/themes/useTheme';
Expand Down Expand Up @@ -29,7 +29,7 @@ type CheckboxProps = ChildrenProps & {
containerStyle?: StyleProp<ViewStyle>;

/** Callback that is called when mousedown is triggered. */
onMouseDown?: () => void;
onMouseDown?: MouseEventHandler;

/** The size of the checkbox container */
containerSize?: number;
Expand Down
1 change: 1 addition & 0 deletions src/components/Icon/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,4 @@ class Icon extends PureComponent<IconProps> {
}

export default withTheme(withThemeStyles(Icon));
export type {SrcProps};
138 changes: 0 additions & 138 deletions src/components/TextInput/BaseTextInput/baseTextInputPropTypes.js

This file was deleted.

Loading
Loading