-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Two tags are highlighted at the same time #31475
Conversation
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -74,7 +62,8 @@ function CategoryPicker({selectedCategory, policyCategories, policyRecentlyUsedC | |||
sections={sections} | |||
selectedOptions={selectedOptions} | |||
value={searchValue} | |||
initialFocusedIndex={initialFocusedIndex} | |||
focusedIndex={0} | |||
initiallyFocusedOptionKey={lodashGet(_.filter(lodashGet(sections, '[0].data', []), (category) => category.searchText === selectedCategory)[0], 'keyForList')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract the value to separate variable and add a comment explaining the logic for initially focused key, same in TagsPicker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
Reviewer Checklist
Screenshots/VideosAndroid: Nativetags-android.movAndroid: mWeb Chrometags-mweb.moviOS: Nativetags-ios.mp4tags-ios1.mp4iOS: mWeb Safaritags-safari.mp4MacOS: Chrome / Safaritags-web.movMacOS: Desktoptags-desktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.3-0 🚀
|
🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.3-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.3-11 🚀
|
Details
When you disable any Tag in OldD in the IOU(NewD) details in the Tag section, two fields are highlighted instead of the one selected. This PR fixes that.
Fixed Issues
$ #30465
PROPOSAL: #30465 (comment)
Tests
Or use mock data here to avoid using OD.
Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2023-11-17.at.15.38.47-compressed.mov
Android: mWeb Chrome
Screen.Recording.2023-11-17.at.15.45.52-compressed.mov
iOS: Native
Screen.Recording.2023-11-17.at.15.53.32-compressed.mov
iOS: mWeb Safari
Screen.Recording.2023-11-17.at.16.02.49-compressed.mov
MacOS: Chrome / Safari
https://github
.com/Expensify/App/assets/113963320/ded7c732-1743-4bcb-8d2d-1a2e84cb7128
MacOS: Desktop
Screen.Recording.2023-11-17.at.16.10.09-compressed.mov