Hide create menu when opening concierge chat by deeplink #31675

dukenv0307 · 2023-11-22T07:40:36Z

Details

Hide create menu when opening concierge chat by deeplink

Fixed Issues

$ #30021
PROPOSAL: #30021 (comment)

Tests

Logout
Go to concierge chat by deep link with new account (verify that this is the first time login in the app)
Sign in and verify that in small screen width, the create menu doesn't appear after signing in successfully
For small screen, click on back button to back to LHN
Verify that create menu appears

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Logout
Go to concierge chat by deep link with new account (verify that this is the first time login in the app)
Sign in and verify that in small screen width, the create menu doesn't appear after signing in successfully
For small screen, click on back button to back to LHN
Verify that create menu appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-1.mov

Android: mWeb Chrome

chrome-1.mov

iOS: Native

ios.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

web-2.mov

MacOS: Desktop

destop-1.mov

melvin-bot · 2023-11-22T07:41:20Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2023-11-22T11:54:35Z

@dukenv0307 Can you add a test step to navigate back to the home and verify that the create menu is open (for mobile)?

This doesn't seem to be working on Android mWeb:

android-chrome-2023-11-22_12.52.33.mp4

Same on iOS native:

ios-native-2023-11-22_13.00.12.mp4

jjcoffee · 2023-11-22T12:04:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native-2023-11-22_12.33.51.mp4

Android: mWeb Chrome

android-chrome-2023-11-30_14.35.33.mp4

iOS: Native

ios-native-2023-11-29_16.06.37.mp4

iOS: mWeb Safari

ios-safari-2023-11-22_13.04.11.mp4

MacOS: Chrome / Safari

mac-chrome-2023-11-22_12.49.11.mp4

MacOS: Desktop

mac-desktop-2023-11-22_12.57.11.mp4

dukenv0307 · 2023-11-23T08:39:43Z

@jjcoffee Seems like the account used in the video was signed in before. I tested with the new account (the first time log in) and it work well.

jjcoffee · 2023-11-23T12:23:30Z

@dukenv0307 Did you test on iOS native? I get it consistently for new accounts, using npx uri-scheme open new-expensify://concierge to simulate the deeplink.

dukenv0307 · 2023-11-24T09:06:45Z

@jjcoffee On native after OpenReport API is called, isFirstTimeNewExpensifyUser is updated to false while in mWeb it's not updated to false. Not sure why this happens on native.

jjcoffee · 2023-11-24T15:54:34Z

@dukenv0307 Okay do you think there's a workaround? I don't think we'd really want to introduce inconsistent behaviour.

dukenv0307 · 2023-11-24T15:56:17Z

@lakchote Can you please confirm here.

lakchote · 2023-11-27T14:26:02Z

@lakchote Can you please confirm here.

I do agree with @jjcoffee, we don't want to introduce inconsistent behaviour. Can you think of a potential workaround @dukenv0307?

dukenv0307 · 2023-11-29T08:19:03Z

@jjcoffee I updated.

jjcoffee · 2023-11-29T15:37:28Z

Getting a different problem now on Android Chrome where we navigate to the "not found" screen first, then the concierge chat, and when you navigate back the FAB is closed. Seems to be happening on main too, so it's not to do with this PR, but I can't test whilst it's happening!

android-chrome-2023-11-29_16.20.47.mp4

dukenv0307 · 2023-11-30T04:26:22Z

@jjcoffee I think it happens because we cannot use dev.new.expensify.com for mWeb android when testing in local.

jjcoffee · 2023-11-30T13:39:48Z

Thanks for the tip @dukenv0307! I finally got it working.

jjcoffee

LGTM!

lakchote · 2023-12-01T06:09:00Z

@jjcoffee @dukenv0307 Thanks both of you for your work!

LGTM 👍

OSBotify · 2023-12-04T05:43:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-05T02:55:59Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-05T13:41:04Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.8-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:31:09Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:40:41Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hide create menu when opening concierge chat by deeplink

32a043b

dukenv0307 marked this pull request as ready for review November 22, 2023 07:41

dukenv0307 requested a review from a team as a code owner November 22, 2023 07:41

melvin-bot bot requested review from jjcoffee and removed request for a team November 22, 2023 07:41

Merge branch 'main' into fix/30021

39cd0c1

Merge branch 'main' into fix/30021

6d7c303

dukenv0307 added 2 commits November 29, 2023 15:18

show create menu when going back

616a4be

Merge branch 'main' into fix/30021

ad3110f

jjcoffee approved these changes Nov 30, 2023

View reviewed changes

melvin-bot bot requested a review from lakchote November 30, 2023 13:40

lakchote approved these changes Dec 1, 2023

View reviewed changes

lakchote merged commit 7fef24c into Expensify:main Dec 4, 2023
16 checks passed

github-actions bot mentioned this pull request Dec 5, 2023

Deploy Checklist: New Expensify 2023-12-05 #32463

Closed

66 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide create menu when opening concierge chat by deeplink #31675

Hide create menu when opening concierge chat by deeplink #31675

dukenv0307 commented Nov 22, 2023 •

edited

Loading

melvin-bot bot commented Nov 22, 2023

jjcoffee commented Nov 22, 2023 •

edited

Loading

jjcoffee commented Nov 22, 2023 •

edited

Loading

dukenv0307 commented Nov 23, 2023

jjcoffee commented Nov 23, 2023

dukenv0307 commented Nov 24, 2023 •

edited

Loading

jjcoffee commented Nov 24, 2023

dukenv0307 commented Nov 24, 2023

lakchote commented Nov 27, 2023

dukenv0307 commented Nov 29, 2023

jjcoffee commented Nov 29, 2023

dukenv0307 commented Nov 30, 2023 •

edited

Loading

jjcoffee commented Nov 30, 2023

jjcoffee left a comment

lakchote commented Dec 1, 2023

OSBotify commented Dec 4, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

Hide create menu when opening concierge chat by deeplink #31675

Hide create menu when opening concierge chat by deeplink #31675

Conversation

dukenv0307 commented Nov 22, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 22, 2023

jjcoffee commented Nov 22, 2023 • edited Loading

jjcoffee commented Nov 22, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

dukenv0307 commented Nov 23, 2023

jjcoffee commented Nov 23, 2023

dukenv0307 commented Nov 24, 2023 • edited Loading

jjcoffee commented Nov 24, 2023

dukenv0307 commented Nov 24, 2023

lakchote commented Nov 27, 2023

dukenv0307 commented Nov 29, 2023

jjcoffee commented Nov 29, 2023

dukenv0307 commented Nov 30, 2023 • edited Loading

jjcoffee commented Nov 30, 2023

jjcoffee left a comment

Choose a reason for hiding this comment

lakchote commented Dec 1, 2023

OSBotify commented Dec 4, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

dukenv0307 commented Nov 22, 2023 •

edited

Loading

jjcoffee commented Nov 22, 2023 •

edited

Loading

jjcoffee commented Nov 22, 2023 •

edited

Loading

dukenv0307 commented Nov 24, 2023 •

edited

Loading

dukenv0307 commented Nov 30, 2023 •

edited

Loading