-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'AnonymousReportFooter.js' component to TypeScript #31916
[TS migration] Migrate 'AnonymousReportFooter.js' component to TypeScript #31916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as always! LGTM
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeScreen.Recording.2023-11-30.at.21.28.52.-.android.chrome.moviOS: mWeb SafariScreen.Recording.2023-11-30.at.21.31.21.-.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2023-11-30.at.21.23.00.-.web.movMacOS: DesktopScreen.Recording.2023-11-30.at.21.26.42.-.desktop.mov |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25058 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.7-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.7-4 🚀
|
Details
[TS migration] Migrate 'AnonymousReportFooter.js' component to TypeScript
Fixed Issues
$ #25058
PROPOSAL: N/A
Tests
For Web/Mobile web/Desktop:
Android:
npx uri-scheme open new-expensify://r/3504895439653267 --android
, it can take a couple of seconds for the app to open the screen.iOS:
npx uri-scheme open new-expensify://r/3504895439653267 --ios
, it can take a couple of seconds for the app to open the screen.Note:
If you have any problems with the steps above, you can also
const isAnonymousUser = true;
Offline tests
N/A
QA Steps
For Web/Mobile web/Desktop:
Android:
npx uri-scheme open new-expensify://r/3504895439653267 --android
, it can take a couple of seconds for the app to open the screen.iOS:
npx uri-scheme open new-expensify://r/3504895439653267 --ios
, it can take a couple of seconds for the app to open the screen.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop