-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeScript Migration] Migrate ReceiptEmptyState.js to TypeScript #32431
[TypeScript Migration] Migrate ReceiptEmptyState.js to TypeScript #32431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JKobrynski Fix how issue is linked in the PR and fill out tests section
@joelbettner Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@blazejkustra @fabioh8010 will one of you do the checklist? |
C+ was supposed to checklist but it seems no C+ assigned here. |
Yes, that is correct, C+ must do the checklist, @situchan Thanks for that! |
@situchan that would be great if you could do the checklist. Thank you! |
@situchan kindly bump 😄 |
@situchan gentle bump |
@JKobrynski please add Tests step. And there's conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fill="transparent"
This prop was removed in #33636
@JKobrynski there are conflicts. |
@joelbettner conflicts resolved! |
@situchan all yours. |
Author Checklist failing. @JKobrynski can you please add missing checklist items recently added? |
@situchan updated! |
@situchan kindly bump 😄 |
please merge main once again |
@situchan done! |
@situchan gentle bump. |
Ah merged early. Reviewer checklist is missing here which I was just about to post. Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@JKobrynski please add QA Steps so QA team know what to test. |
🚀 Deployed to staging by https://github.com/joelbettner in version: 1.4.29-0 🚀
|
🚀 Deployed to staging by https://github.com/joelbettner in version: 1.4.29-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.29-1 🚀
|
Details
Fixed Issues
$ #31940
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as Tests section above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop