Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍒 Cherry pick PR #32516 to staging 🍒 #32530

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

os-botify[bot]
Copy link

@os-botify os-botify bot commented Dec 5, 2023

🍒 Cherry pick #32516 to staging 🍒

OSBotify and others added 2 commits December 5, 2023 21:57
(cherry picked from commit 2c1ee2a)
[CP Staging] Manually revert "Merge pull request #31467 from dukenv0307/fix/31105"

(cherry picked from commit 62ef87a)
@os-botify os-botify bot requested a review from a team as a code owner December 5, 2023 21:57
@os-botify
Copy link
Author

os-botify bot commented Dec 5, 2023

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

@melvin-bot melvin-bot bot requested review from jasperhuangg and removed request for a team December 5, 2023 21:58
Copy link

melvin-bot bot commented Dec 5, 2023

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

mountiny commented Dec 5, 2023

image

Tested seems to be fine

Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mountiny looks pretty good except one thing

Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, given that it tests well.

@mountiny mountiny merged commit 36dca8f into staging Dec 5, 2023
2 of 10 checks passed
@mountiny mountiny deleted the mountiny-cherry-pick-staging-32516-1 branch December 5, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants