Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: optimise transition on Desktop when click on start chat #33055

Merged
merged 11 commits into from
Jan 10, 2024
Merged

perf: optimise transition on Desktop when click on start chat #33055

merged 11 commits into from
Jan 10, 2024

Commits on Dec 14, 2023

  1. refactor: change to useActiveElementRole 

    Since we are only using role property from the element, so it sounds better to store only the role property in the hook.
    @hurali97
    hurali97 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1bb1b1e View commit details
    Browse the repository at this point in the history

  2. refactor: separate logic for keyboard shortcut in a leaf component 

    Doing so, re-render won't render the parent Button component
    @hurali97
    hurali97 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f526678 View commit details
    Browse the repository at this point in the history

  3. perf: update the options once screen transition is finished

    @hurali97
    hurali97 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c3507cc View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/desktop-start-chat-transition-lag
    @hurali97
    hurali97 committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    69daf4d View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/desktop-start-chat-transition-lag
    @hurali97
    hurali97 committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5db0c22 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/desktop-start-chat-transition-lag
    @hurali97
    hurali97 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    23800dc View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/desktop-start-chat-transition-lag
    @hurali97
    hurali97 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    50f8558 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/desktop-start-chat-transition-lag
    @hurali97
    hurali97 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    1520de2 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. fix: infinite skeleton loader

    @hurali97
    hurali97 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    29c796e View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/desktop-start-chat-transition-lag
    @hurali97
    hurali97 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f912b63 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/desktop-start-chat-transition-lag
    @hurali97
    hurali97 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    3ee3afa View commit details
    Browse the repository at this point in the history