-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'Section.js' component to TypeScript #33645
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9072dbc
[TS migration] Migrate 'Section.js' component to TypeScript
blazejkustra fe57401
Adjust MenuItem and MenuItemList
blazejkustra 2a50e51
Fix package.json
blazejkustra 15f4ed5
Merge branch 'main' into ts/Section
blazejkustra b90b5da
Merge branch 'main' into ts/Section
blazejkustra 9974e38
Merge branch 'main' into ts/Section
blazejkustra 60e0c99
Rerun checks
blazejkustra 0c8274a
Merge branch 'main' into ts/Section
blazejkustra 63a7d25
Merge branch 'main' into ts/Section
blazejkustra 4cebe6a
Fix typecheck
blazejkustra 09a65e6
Fix type imports
blazejkustra 56a99fa
Merge branch 'main' into ts/Section
blazejkustra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for this removal? This automatically enabled interactive when onPress is defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please have a look at this discussion