Fix/32875/svg color and olddot url #33863

barttom · 2024-01-03T08:31:21Z

Details

Fixed Issues

$ #32875
$ #33284
$ #33519
PROPOSAL: -

Tests

Open the app
Open settings
Click 'Go to Expnesify Classic'

Observe that the user should be redirected to the old dot inbox page. Address depends of environment
Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app
Open settings
Click 'Go to Expnesify Classic'

Observe that the user should be redirected to the old dot inbox page. Address depends of environment
Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

33863_android.mov

Android: mWeb Chrome

iOS: Native

33863_ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

33863_web.mov

MacOS: Desktop

melvin-bot · 2024-01-03T09:21:33Z

@dubielzyk-expensify @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dubielzyk-expensify

From a UI perspective this looks good to me 👍

MitchExpensify · 2024-01-05T04:14:53Z

Friendly bump @eVoloshchak

pecanoro · 2024-01-08T09:23:53Z

Reassigning to @thesahindia instead since he was the original reviewer and assigned C+ to the issue.

thesahindia · 2024-01-08T19:24:20Z

@barttom, shouldn't I get logged into old dot?

Screen.Recording.2024-01-09.at.12.48.33.AM.mov

MitchExpensify · 2024-01-09T02:50:12Z

shouldn't I get logged into old dot?

Yes, you should

barttom · 2024-01-09T07:00:01Z

@thesahindia Take a look at the url. Probably DEV instance for olddot doesn't exist.
I don't know how to test it properly in the dev environment. I think we need to build staging or prod locally, ndon't know how to do that.
I used Link.openOldDotLink method that was used in similar cases, so I assumed this function would redirect to the proper olddot instance depending on the environment.

pecanoro · 2024-01-09T08:38:19Z

@barttom is right, it redirects you to the local dev environment for oldDot. I can test it as well, but for now, for the videos, could you guys just modify getOldDotEnvironmentURL to point always be staging and check if it is working?

pecanoro · 2024-01-09T13:15:38Z

It works on dev for web, I haven't tested the other platforms yet.

Monosnap.screencast.2024-01-09.14-14-11.mp4

thesahindia · 2024-01-10T10:01:20Z

That makes sense!

pecanoro · 2024-01-10T11:38:59Z

@thesahindia @barttom Could you guys update the video by forcing the JS function to go to staging?

pecanoro · 2024-01-10T11:41:38Z

src/pages/settings/InitialSettingsPage.js

@@ -128,6 +128,8 @@ const defaultProps = {
    ...withCurrentUserPersonalDetailsDefaultProps,
 };

+const INBOX_URL = 'inbox';


Can we move this to CONST and also replace it in places like this one?

App/src/pages/settings/Wallet/ExpensifyCardPage.js

Line 211 in c0313c2

onPress={() => Link.openOldDotLink('inbox')}

@barttom Friendly bump to address this one last comment

Thanks, done :)

thesahindia · 2024-01-10T11:42:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-10.at.4.58.51.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-01-10.at.5.00.41.PM.mov

iOS: Native

Screen.Recording.2024-01-10.at.4.51.55.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-10.at.4.55.33.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-10.at.4.44.55.PM.mov

MacOS: Desktop

Screen.Recording.2024-01-10.at.3.58.14.PM.mov

thesahindia

LGTM!

thesahindia · 2024-01-10T11:44:27Z

@thesahindia @barttom Could you guys update the video by forcing the JS function to go to staging?

Added them in #33863 (comment)

pecanoro · 2024-01-15T10:18:10Z

@barttom Not a huge deal in this one, but as specified here, please don't force push after the review has started!

OSBotify · 2024-01-15T10:26:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

barttom · 2024-01-15T10:41:02Z

@pecanoro I had conflicts here and needed to rebase my branch, so that's why I used 'force' flag

OSBotify · 2024-01-15T11:57:26Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-17T01:15:10Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ishpaul777 · 2024-02-16T18:16:10Z

src/pages/settings/InitialSettingsPage.js

                },
                shouldShowRightIcon: true,
                iconRight: Expensicons.NewWindow,
-                link: CONST.EXPENSIFY_INBOX_URL,
+                link: Link.buildOldDotURL(CONST.OLDDOT_URLS.INBOX),


This caused a regression here #35310, Link.buildOldDotURL returns a promise not a string

barttom marked this pull request as ready for review January 3, 2024 09:21

barttom requested a review from a team as a code owner January 3, 2024 09:21

melvin-bot bot requested review from dubielzyk-expensify and eVoloshchak and removed request for a team January 3, 2024 09:21

dubielzyk-expensify previously approved these changes Jan 3, 2024

View reviewed changes

pecanoro requested review from thesahindia and removed request for eVoloshchak January 8, 2024 09:23

pecanoro self-requested a review January 8, 2024 09:23

pecanoro mentioned this pull request Jan 8, 2024

[HOLD for payment 2024-01-24] [HOLD PR #33863][$500] Settings - Expensify icon of "Go to Expensify Classic" option doesn't turn to white when hover #33519

Closed

6 tasks

pecanoro requested changes Jan 10, 2024

View reviewed changes

thesahindia approved these changes Jan 10, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi January 10, 2024 11:42

pecanoro removed the request for review from srikarparsi January 11, 2024 10:15

barttom dismissed dubielzyk-expensify’s stale review via 0e9ab90 January 11, 2024 19:22

barttom force-pushed the fix/32875/svg-color-and-olddot-url branch from e1a674a to 0e9ab90 Compare January 11, 2024 19:22

barttom added 2 commits January 15, 2024 08:56

fix: fixed color style in icon, changed way of redirecting to the olddot

d3da565

refactor: move inbox url to the const

cc02642

barttom force-pushed the fix/32875/svg-color-and-olddot-url branch from 0e9ab90 to cc02642 Compare January 15, 2024 08:02

pecanoro approved these changes Jan 15, 2024

View reviewed changes

pecanoro merged commit 2be282e into Expensify:main Jan 15, 2024
15 checks passed

github-actions bot mentioned this pull request Jan 15, 2024

Deploy Checklist: New Expensify 2024-01-15 #34493

Closed

83 tasks

This was referenced Jan 17, 2024

[HOLD for payment 2024-03-05] [Contributor] Add Visit Expensify Classic Button to NewDot #32875

Closed

[HOLD for payment 2024-01-24] Settings - 'Go to Expensify Classic' options redirect to prod, not STG version #33284

Closed

jeremy-croff mentioned this pull request Jan 24, 2024

[HOLD for payment 2024-03-07] Splash logo icon is black instead of green (prod only) #35018

Closed

6 tasks

ishpaul777 mentioned this pull request Feb 16, 2024

[HOLD for payment 2024-02-14] [$500] Long pressing "Go to Expensify Classic" option in Settings Crashes the App #35310

Closed

6 tasks

ishpaul777 reviewed Feb 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/32875/svg color and olddot url #33863

Fix/32875/svg color and olddot url #33863

barttom commented Jan 3, 2024 •

edited

Loading

melvin-bot bot commented Jan 3, 2024

dubielzyk-expensify left a comment

MitchExpensify commented Jan 5, 2024

pecanoro commented Jan 8, 2024

thesahindia commented Jan 8, 2024

MitchExpensify commented Jan 9, 2024

barttom commented Jan 9, 2024

pecanoro commented Jan 9, 2024

pecanoro commented Jan 9, 2024

thesahindia commented Jan 10, 2024

pecanoro commented Jan 10, 2024

pecanoro Jan 10, 2024

pecanoro Jan 11, 2024

barttom Jan 11, 2024

thesahindia commented Jan 10, 2024

thesahindia left a comment

thesahindia commented Jan 10, 2024

pecanoro commented Jan 15, 2024

OSBotify commented Jan 15, 2024

barttom commented Jan 15, 2024

OSBotify commented Jan 15, 2024

OSBotify commented Jan 17, 2024

ishpaul777 Feb 16, 2024

Fix/32875/svg color and olddot url #33863

Fix/32875/svg color and olddot url #33863

Conversation

barttom commented Jan 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 3, 2024

dubielzyk-expensify left a comment

Choose a reason for hiding this comment

MitchExpensify commented Jan 5, 2024

pecanoro commented Jan 8, 2024

thesahindia commented Jan 8, 2024

MitchExpensify commented Jan 9, 2024

barttom commented Jan 9, 2024

pecanoro commented Jan 9, 2024

pecanoro commented Jan 9, 2024

thesahindia commented Jan 10, 2024

pecanoro commented Jan 10, 2024

pecanoro Jan 10, 2024

Choose a reason for hiding this comment

pecanoro Jan 11, 2024

Choose a reason for hiding this comment

barttom Jan 11, 2024

Choose a reason for hiding this comment

thesahindia commented Jan 10, 2024

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

thesahindia commented Jan 10, 2024

pecanoro commented Jan 15, 2024

OSBotify commented Jan 15, 2024

barttom commented Jan 15, 2024

OSBotify commented Jan 15, 2024

OSBotify commented Jan 17, 2024

ishpaul777 Feb 16, 2024

Choose a reason for hiding this comment

barttom commented Jan 3, 2024 •

edited

Loading