Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move location bias calculation to hook and use it on edit #33887

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Move location bias calculation to hook and use it on edit #33887

merged 3 commits into from
Jan 3, 2024

Conversation

aldo-expensify
Copy link
Contributor

@aldo-expensify aldo-expensify commented Jan 3, 2024 •
edited
Loading

Details

Fixed Issues

$ #33877
PROPOSAL: #33877 (comment)

Tests

  1. Create a workspace and go to your workspace expense chat
  2. Create a distance request and allow the browser to give your location
  3. Type an a in the first waypoint and confirm that the locations offered are biased by your real location
  4. Choose two waypoints not too far from you and finish creating the distance request
  5. Go to the distance request transaction and edit the "Distance" field
  6. Edit the first waypoint and replace its content by an a
  7. Verify that the suggested addresses are biased by your location
  8. Open an incognito window and login in the same account
  9. Create a distance request and this time DON'T allow the browser to give your location
  10. Type an a in the first waypoint and confirm that the locations offered are not biased by your real location and that the page doesn't crash
  11. Choose two waypoints not too far from you and finish creating the distance request
  12. Go to the distance request transaction and edit the "Distance" field
  13. Edit the first waypoint and replace its content by an a
  14. Verify that the suggested addresses are biased by the locations you chose previously
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Create a workspace and go to your workspace expense chat
  2. Create a distance request and allow the browser to give your location
  3. Type an a in the first waypoint and confirm that the locations offered are biased by your real location
  4. Choose two waypoints not too far from you and finish creating the distance request
  5. Go to the distance request transaction and edit the "Distance" field
  6. Edit the first waypoint and replace its content by an a
  7. Verify that the suggested addresses are biased by your location
  8. Open an incognito window and login in the same account
  9. Create a distance request and this time DON'T allow the browser to give your location
  10. Type an a in the first waypoint and confirm that the locations offered are not biased by your real location and that the page doesn't crash
  11. Choose two waypoints not too far from you and finish creating the distance request
  12. Go to the distance request transaction and edit the "Distance" field
  13. Edit the first waypoint and replace its content by an a
  14. Verify that the suggested addresses are biased by the locations you chose previously
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-01-03.at.3.04.05.PM.mov
MacOS: Desktop

@aldo-expensify aldo-expensify self-assigned this Jan 3, 2024
@aldo-expensify aldo-expensify requested a review from a team as a code owner January 3, 2024 17:54
@melvin-bot melvin-bot bot requested review from mananjadhav and removed request for a team January 3, 2024 17:55
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 3, 2024

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@aldo-expensify
Copy link
Contributor Author

@mananjadhav are you around to review this?

@aldo-expensify aldo-expensify requested review from allroundexperts and removed request for mananjadhav January 3, 2024 18:10
@allroundexperts
Copy link
Contributor

allroundexperts commented Jan 3, 2024 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Screen.Recording.2024-01-04.at.12.44.23.AM.mov
Android: mWeb Chrome
Screen.Recording.2024-01-04.at.12.15.39.AM.mov
iOS: Native
Screen.Recording.2024-01-04.at.12.12.49.AM.mov
iOS: mWeb Safari
Screen.Recording.2024-01-03.at.11.55.55.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-01-03.at.11.48.05.PM.mp4
MacOS: Desktop
Screen.Recording.2024-01-03.at.11.53.00.PM.mov

@allroundexperts
Copy link
Contributor

Probably not related to this PR, but the iOS app is crashing once I open the newly created distance request:

Screen.Recording.2024-01-04.at.12.24.20.AM.mov

@aldo-expensify
Copy link
Contributor Author

Probably not related to this PR, but the iOS app is crashing once I open the newly created distance request:

Hmm, looks unrelated by looking at the crash line. Maybe we should still confirm if the crash happens in main.

@allroundexperts
Copy link
Contributor

Happens on main as well!

allroundexperts
allroundexperts approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@allroundexperts allroundexperts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@melvin-bot melvin-bot bot requested a review from yuwenmemon January 3, 2024 19:49
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 3, 2024

@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@aldo-expensify
Copy link
Contributor Author

Happens on main as well!

Thanks for confirming and for the quick review!

@aldo-expensify aldo-expensify merged commit 1037c94 into main Jan 3, 2024
17 checks passed
@aldo-expensify aldo-expensify deleted the aldo_enable-location-bias-on-edit branch January 3, 2024 22:01
@OSBotify
Copy link
Contributor

OSBotify commented Jan 3, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jan 3, 2024
@aldo-expensify @OSBotify
Merge pull request #33887 from Expensify/aldo_enable-location-bias-on…
741f3ff 
…-edit

Move location bias calculation to hook and use it on edit

(cherry picked from commit 1037c94)
@github-actions github-actions bot mentioned this pull request Jan 3, 2024
Closed
58 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2024

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.21-3 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2024

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.21-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2024

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.21-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@aldo-expensify aldo-expensify mentioned this pull request Jan 4, 2024
Closed
6 tasks
@aldo-expensify
Copy link
Contributor Author

QA pass

Screen.Recording.2024-01-04.at.12.04.19.AM.mov

@kbecciv kbecciv mentioned this pull request Jan 4, 2024
Closed
6 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2024

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2024

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2024

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allroundexperts allroundexperts allroundexperts approved these changes

@yuwenmemon yuwenmemon yuwenmemon approved these changes

Assignees

@aldo-expensify aldo-expensify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aldo-expensify @allroundexperts @OSBotify @yuwenmemon