-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'ReportActionItemMessageEdit.js' component to TypeScript #34091
[TS migration] Migrate 'ReportActionItemMessageEdit.js' component to TypeScript #34091
Conversation
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@yh-0218 Please fill out Tests and QA Tests sections, fix Author reviewer checklist + kind request, change PR title so it reflects issue title: [TS migration] Migrate 'X.js' component to TypeScript |
@blazejkustra PR is ready |
@blazejkustra Could you check last commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript wise, looks good
Hello, @srikarparsi PR is ready. Thanks. |
@yh-0218 please link issue correctly from next PRs. Incorrect format breaks automation and assigns wrong people. wrong: correct: |
hi, @fedirjh Could you check again? |
Reviewer Checklist
Screenshots/VideosAndroid: NativeCleanShot.2024-01-10.at.15.42.18.mp4Android: mWeb ChromeCleanShot.2024-01-10.at.15.46.42.mp4iOS: NativeCleanShot.2024-01-10.at.15.59.45.mp4iOS: mWeb SafariCleanShot.2024-01-10.at.16.04.07.mp4MacOS: Chrome / SafariCleanShot.2024-01-10.at.14.48.47.mp4MacOS: DesktopCleanShot.2024-01-10.at.16.12.46.mp4 |
hello, @srikarparsi Could you check this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.24-4 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.24-8 🚀
|
Details
Fixed Issues
$ #31974
PROPOSAL: N/A
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop