-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repeated calls to SignInWithShortLivedAuthToken #34305
Conversation
@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This is ready for review. Lint errors are unrelated and hopefully will be fixed soon on |
@arosiclair How to test this? Old dot will redirect to the production app on new workspace creation how to test this in dev? |
Can you try copying the link that OldDot opens and replacing If that doesn't work, I'll have someone test it internally. |
@arosiclair I was able to test this. However, I was able to copy the URL before redirecting. Using the same URL just changing the prefix dev/staging/production(new) environments. Should we allow to use of the token multiple times across different environments? |
I'm not sure, but it shouldn't matter either way. |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2024-01-13.at.12.58.14.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -398,7 +398,7 @@ function setUpPoliciesAndNavigate(session: OnyxEntry<OnyxTypes.Session>) { | |||
return; | |||
} | |||
if (!isLoggingInAsNewUser && exitTo) { | |||
Navigation.isNavigationReady() | |||
Navigation.waitForProtectedRoutes() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to waiting for the navigation to be "ready", waitForProtectedRoutes
waits for one of our authenticated routes (like the LHN or a report) to be rendered.
Atm isNavigationReady
is a bit of a hack (it gets triggered here) and doesn't work very well in testing , but this works consistently.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/grgia in version: 1.4.25-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀
|
Details
Optimizes LogOutPreviousUserPage by removing a redundant navigation and removing its effect's dependency on all props.
Fixed Issues
$ #33413
Tests
Web only
Creating a workspace while signed out
Opening an existing workspace
Creating a workspace while signed in
Creating a workspace while signed into another account
Offline tests
None
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop