Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Add layout=narrow initial param to the ModalStackNavigator" #34552

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[CP Staging] Revert "Add layout=narrow initial param to the ModalStackNavigator" #34552

merged 1 commit into from
Jan 16, 2024

Conversation

marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Jan 16, 2024 •
edited by mountiny
Loading

Reverts #33426

Fixing #34532

@marcochavezf marcochavezf marked this pull request as ready for review January 16, 2024 04:43
@marcochavezf marcochavezf requested a review from a team as a code owner January 16, 2024 04:43
@melvin-bot melvin-bot bot requested review from yuwenmemon and removed request for a team January 16, 2024 04:44
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 16, 2024

@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marcochavezf marcochavezf mentioned this pull request Jan 16, 2024
Closed
6 tasks
@mountiny mountiny changed the title Revert "Add layout=narrow initial param to the ModalStackNavigator" [CP Staging] Revert "Add layout=narrow initial param to the ModalStackNavigator" Jan 16, 2024
@mountiny
Copy link
Contributor

Straight revert, no need for checklists

mountiny
mountiny approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit 925dc3d into main Jan 16, 2024
13 of 16 checks passed
@mountiny mountiny deleted the revert-33426-add-the-isInRHP-prop-to-the-ModalStackNavigator branch January 16, 2024 11:37
@melvin-bot melvin-bot bot added the Emergency label Jan 16, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 16, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

Straight revert

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jan 16, 2024
@mountiny @OSBotify
Merge pull request #34552 from Expensify/revert-33426-add-the-isInRHP…
4a7d4f9 
…-prop-to-the-ModalStackNavigator

[CP Staging] Revert "Add layout=narrow initial param to the ModalStackNavigator"

(cherry picked from commit 925dc3d)
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Closed
83 tasks
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.25-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.25-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@yuwenmemon yuwenmemon Awaiting requested review from yuwenmemon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcochavezf @mountiny @OSBotify