[TS migration] Migrate RoomMembersPage to typescript #34957

SzymczakJ · 2024-01-23T10:45:03Z

Details

Fixed Issues

$ #31995
PROPOSAL: N/A

Tests

Test main flows of the app(sending messages, logging, requesting money)
Verify that members page for a room work correctly

Offline tests

QA Steps

Same as tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

androidweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

iosweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

src/pages/RoomMembersPage.tsx

VickyStash · 2024-02-06T12:27:11Z

src/pages/RoomMembersPage.tsx

+            if (!member.accountID) {
+                return false;
+            }
+            return selectedMembers.includes(member.accountID);


Since you updated the logic (use accountID instead of keyForList), make sure the functionality works as expected.

yep, keyForList is actually string created by String(accountId)
result.push({ keyForList: String(accountID),
so instead of doing Number(keyForList) I'm doing accountId
Made sure everything works as expected 😃

VickyStash

Minor comments, LGTM

src/pages/RoomMembersPage.tsx

melvin-bot · 2024-02-07T13:28:31Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-02-07T13:44:53Z

I’ll review this in an hour.

SzymczakJ · 2024-02-08T11:06:25Z

@mananjadhav quick reminder 😃

mananjadhav · 2024-02-08T13:40:25Z

Reviewing this at the moment.

mananjadhav · 2024-02-08T13:43:54Z

src/pages/RoomMembersPage.tsx

-        Report.openRoomMembersPage(props.report.reportID);
+        if (report) {
+            Report.openRoomMembersPage(report.reportID);
+        }
        setDidLoadRoomMembers(true);


Should we setting this true even if report is not set?

mananjadhav · 2024-02-08T13:45:17Z

src/pages/RoomMembersPage.tsx

@@ -95,71 +61,67 @@ function RoomMembersPage(props) {
     */
    const inviteUser = () => {
        setSearchValue('');
-        Navigation.navigate(ROUTES.ROOM_INVITE.getRoute(props.report.reportID));
+        if (report) {


Same here as well? Also do we have any case where report will not be defined?

mananjadhav · 2024-02-08T18:26:59Z

src/pages/RoomMembersPage.tsx

+                isSelected: selectedMembers.includes(accountID),
+                isDisabled: accountID === session?.accountID,
+                text: formatPhoneNumber(PersonalDetailsUtils.getDisplayNameOrDefault(details)),
+                alternateText: details.login ? formatPhoneNumber(details.login) : '',


Do we need this check? I can see formatPhoneNumber accepts undefined.

mananjadhav · 2024-02-08T18:28:10Z

src/pages/RoomMembersPage.tsx

+                isDisabled: accountID === session?.accountID,
+                text: formatPhoneNumber(PersonalDetailsUtils.getDisplayNameOrDefault(details)),
+                alternateText: details.login ? formatPhoneNumber(details.login) : '',
+                icons: details.login


I am trying to make out if this has an odd impact because of this change? I can see earlier we would still have source and type if details.login not set.

mananjadhav · 2024-02-08T18:33:10Z

src/pages/RoomMembersPage.tsx

+                subtitleKey={isEmptyObject(report) ? undefined : 'roomMembersPage.notAuthorized'}
+                onBackButtonPress={() => {
+                    if (!report) {
+                        return;


Instead of return should we just call goBack as fallback?

mananjadhav · 2024-02-08T18:33:37Z

src/pages/RoomMembersPage.tsx

                    onBackButtonPress={() => {
                        setSearchValue('');
-                        Navigation.goBack(ROUTES.REPORT_WITH_ID_DETAILS.getRoute(props.report.reportID));
+                        if (!report) {
+                            return;


Same here? should we goBack?

SzymczakJ · 2024-02-09T11:12:03Z

@mananjadhav just fixed the comments!

mananjadhav · 2024-02-09T16:09:41Z

Thanks the code changes look good but we've got conflicts. Can you please resolve them?

SzymczakJ · 2024-02-12T10:21:10Z

@mananjadhav I've just resolved

mananjadhav · 2024-02-12T14:04:41Z

Thanks, working on the checklist now.

mananjadhav · 2024-02-12T14:05:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-room-members.mov

Android: mWeb Chrome

mweb-chrome-room-members.mov

iOS: Native

ios-room-members.mov

iOS: mWeb Safari

mweb-safari-room-members.mov

MacOS: Chrome / Safari

web-room-members_oUWGv6fx.mp4

MacOS: Desktop

desktop-room-members.mov

melvin-bot · 2024-02-12T19:18:27Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31995 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

mananjadhav · 2024-02-12T19:24:49Z

Approved again so that @lakchote is assigned to the PR.

mananjadhav · 2024-02-13T07:44:23Z

@SzymczakJ Can we please resolve conflicts?

SzymczakJ · 2024-02-13T10:53:21Z

@mananjadhav solved conflicts for good. I hope... 😄

mananjadhav · 2024-02-13T12:10:05Z

Thanks @SzymczakJ. Did Sanity on web again. @lakchote All yours.

SzymczakJ · 2024-02-15T12:13:43Z

@lakchote quick reminder 😄

OSBotify · 2024-02-16T07:45:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-19T23:46:49Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-26T20:52:53Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

SzymczakJ added 4 commits January 23, 2024 10:49

migrate RoomMembersPage to TS

58bf6c4

delete RoomMembersPage

d6381c1

Merge branch 'main' into @szymczak/RoomMembersPage

c8fbd90

fix types after sectionlist merge

c524aba

blazejkustra suggested changes Feb 1, 2024

View reviewed changes

SzymczakJ added 3 commits February 1, 2024 16:46

fix comments

c0d2681

Merge branch 'main' into @szymczak/RoomMembersPage

808919b

fix lint warnings

dc472c5

blazejkustra approved these changes Feb 1, 2024

View reviewed changes

VickyStash reviewed Feb 6, 2024

View reviewed changes

Merge branch 'main' into @szymczak/RoomMembersPage

818c68e

SzymczakJ requested a review from VickyStash February 7, 2024 10:38

fix pr comments

4feaa63

VickyStash approved these changes Feb 7, 2024

View reviewed changes

src/pages/RoomMembersPage.tsx Show resolved Hide resolved

src/pages/RoomMembersPage.tsx Show resolved Hide resolved

fix PR comments

c906794

SzymczakJ marked this pull request as ready for review February 7, 2024 13:28

SzymczakJ requested a review from a team as a code owner February 7, 2024 13:28

melvin-bot bot requested review from mananjadhav and removed request for a team February 7, 2024 13:28

mananjadhav reviewed Feb 8, 2024

View reviewed changes

fix PR comments

d7c8fb4

SzymczakJ force-pushed the @szymczak/RoomMembersPage branch from 529dc85 to d7c8fb4 Compare February 9, 2024 14:30

Merge branch 'main' into @szymczak/RoomMembersPage

130b05b

mananjadhav approved these changes Feb 12, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote February 12, 2024 19:24

Merge branch 'main' into @szymczak/RoomMembersPage

83c91a8

SzymczakJ added 3 commits February 14, 2024 11:04

Merge branch 'main' into @szymczak/RoomMembersPage

5d6cec8

fix merge bug

5a6196b

Merge branch 'main' into @szymczak/RoomMembersPage

317aff7

lakchote approved these changes Feb 16, 2024

View reviewed changes

lakchote merged commit e3331db into Expensify:main Feb 16, 2024
15 checks passed

github-actions bot mentioned this pull request Feb 19, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

sakluger mentioned this pull request Mar 5, 2024

[Hold for payment 2024-03-04][$250][TS migration] Migrate 'RoomMembers' page to TypeScript #31995

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate RoomMembersPage to typescript #34957

[TS migration] Migrate RoomMembersPage to typescript #34957

SzymczakJ commented Jan 23, 2024 •

edited

Loading

VickyStash Feb 6, 2024

SzymczakJ Feb 7, 2024

VickyStash left a comment

melvin-bot bot commented Feb 7, 2024

mananjadhav commented Feb 7, 2024

SzymczakJ commented Feb 8, 2024

mananjadhav commented Feb 8, 2024

mananjadhav Feb 8, 2024

mananjadhav Feb 8, 2024

mananjadhav Feb 8, 2024

mananjadhav Feb 8, 2024

mananjadhav Feb 8, 2024

mananjadhav Feb 8, 2024

SzymczakJ commented Feb 9, 2024

mananjadhav commented Feb 9, 2024

SzymczakJ commented Feb 12, 2024

mananjadhav commented Feb 12, 2024

mananjadhav commented Feb 12, 2024 •

edited

Loading

melvin-bot bot commented Feb 12, 2024

mananjadhav commented Feb 12, 2024

mananjadhav commented Feb 13, 2024

SzymczakJ commented Feb 13, 2024

mananjadhav commented Feb 13, 2024

SzymczakJ commented Feb 15, 2024

OSBotify commented Feb 16, 2024

OSBotify commented Feb 19, 2024

OSBotify commented Feb 26, 2024

[TS migration] Migrate RoomMembersPage to typescript #34957

[TS migration] Migrate RoomMembersPage to typescript #34957

Conversation

SzymczakJ commented Jan 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VickyStash left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Feb 7, 2024

mananjadhav commented Feb 7, 2024

SzymczakJ commented Feb 8, 2024

mananjadhav commented Feb 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SzymczakJ commented Feb 9, 2024

mananjadhav commented Feb 9, 2024

SzymczakJ commented Feb 12, 2024

mananjadhav commented Feb 12, 2024

mananjadhav commented Feb 12, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Feb 12, 2024

mananjadhav commented Feb 12, 2024

mananjadhav commented Feb 13, 2024

SzymczakJ commented Feb 13, 2024

mananjadhav commented Feb 13, 2024

SzymczakJ commented Feb 15, 2024

OSBotify commented Feb 16, 2024

OSBotify commented Feb 19, 2024

OSBotify commented Feb 26, 2024

SzymczakJ commented Jan 23, 2024 •

edited

Loading

mananjadhav commented Feb 12, 2024 •

edited

Loading