-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow accessing the members page in a thread #34993
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d5c50b6
allow accessing the members page in a thread
jasperhuangg 545e368
restrict to chat reports
jasperhuangg c644fd0
update condition, add comment
jasperhuangg a7bfccb
style
jasperhuangg 13cb504
fix conflicts
jasperhuangg 6708926
simplify condition
jasperhuangg 7ca3f44
fix conflicts
jasperhuangg fe3cdf8
don't allow invites in Concierge reports
jasperhuangg f37d119
remove unused import
jasperhuangg 3580072
Merge branch 'main' of github.com:Expensify/App into jasper-allowInvi…
jasperhuangg 5bd9652
hide members page in Concierge DM
jasperhuangg 15a94f9
allow viewing members page in Concierge DM
jasperhuangg 7d9e16c
enable inviting in all threads
jasperhuangg c9b4140
fix behavior
jasperhuangg 9c9863a
fix behavior
jasperhuangg d98a459
fix behavior for public rooms
jasperhuangg ee6a2b5
lint
jasperhuangg c062879
Merge branch 'main' of github.com:Expensify/App into jasper-allowInvi…
jasperhuangg a93f1c5
use correct variable naming
jasperhuangg 9860894
add missing hook dependencies
jasperhuangg c4ee5d3
Update ReportDetailsPage.tsx
jasperhuangg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: these conditions are super confusing and I'd be surprised if somebody doesn't break these eventually. No idea how to simplify things, but something we should consider in case we have to revisit this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree, I was thinking of ways to simplify them but that would involve touching a bunch of other flows, so I elected to keep them the same for now so we could get them out sooner.