Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't persist error after reconnecting with plaid #35117

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Don't persist error after reconnecting with plaid #35117

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
683d5b7
reset bank account and errors in the event that the users starts thei…
NikkiWines Jan 24, 2024
df44ace
don't reset bank account data
NikkiWines Jan 24, 2024
803bae6
remove shouldShowContinueSetupButton check and add blank line above c…
NikkiWines Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/pages/ReimbursementAccount/ReimbursementAccountPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,10 @@ function ReimbursementAccountPage({reimbursementAccount, route, onfidoToken, pol

const currentStepRouteParam = getStepToOpenFromRouteParams(route);
if (currentStepRouteParam === currentStep) {
// If the user is connecting online with plaid, reset any bank account errors so we don't persist old data from a potential previous connection
if (currentStep === CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT && achData.subStep === CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID && !shouldShowContinueSetupButton) {
NikkiWines marked this conversation as resolved.
Show resolved Hide resolved
BankAccounts.hideBankAccountErrors();
}
NikkiWines marked this conversation as resolved.
Show resolved Hide resolved
// The route is showing the correct step, no need to update the route param or clear errors.
return;
}
Expand Down
Loading