-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix selection handle hidden in mobile chrome #35119
Fix selection handle hidden in mobile chrome #35119
Conversation
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -446,7 +447,7 @@ function BaseTextInput( | |||
]} | |||
onLayout={(e) => { | |||
let additionalWidth = 0; | |||
if (Browser.isMobileSafari() || Browser.isSafari()) { | |||
if (Browser.isMobileSafari() || Browser.isSafari() || Browser.isMobileChrome()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be concized to Browser.isMobile() || Browser.isSafari()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishpaul777 I'm not sure how it will behave in other browsers, I think it will be safe to keep it limited to our supported browsers
Here are listed browsers in isMobile
function
Android|webOS|iPhone|iPad|iPod|BlackBerry|BB|PlayBook|IEMobile|Windows Phone|Silk|Opera Mini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One Minor comment other than that Looks good 👍
@@ -435,6 +435,7 @@ function BaseTextInput( | |||
*/} | |||
{(!!autoGrow || autoGrowHeight) && ( | |||
// Add +2 to width on Safari browsers so that text is not cut off due to the cursor or when changing the value | |||
// For mobile Chrome, this will ensure that the text selection handle (blue bubble down) is shown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link to #34921
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added the link, pr updated
Reviewer Checklist
Screenshots/VideosAndroid: NativeRecord_2024-01-25-08-02-08.mp4Android: mWeb ChromeRecord_2024-01-25-07-53-02.mp4iOS: NativeScreen.Recording.2024-01-25.at.7.47.30.AM-1.moviOS: mWeb SafariScreen.Recording.2024-01-25.at.7.49.45.AM-1.movMacOS: Chrome / SafariScreen.Recording.2024-01-25.at.8.26.09.AM.movMacOS: DesktopScreen.Recording.2024-01-25.at.8.43.05.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT
Co-authored-by: Ishpaul Singh <104348397+ishpaul777@users.noreply.github.com>
@ishpaul777, @srikarparsi how to re-run check without pushing any code? seems performance test result is invalid |
…x/34921-selection-handle-hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All yours! @srikarparsi
@srikarparsi do you have any additional thoughts or feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.33-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀
|
@ishpaul777, @srikarparsi
Details
Add more width to show hidden selection handle in mobile chrome
Fixed Issues
$ #34921
PROPOSAL: #34921 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-01-25.at.07.20.40.mov
Android: mWeb Chrome
Screen.Recording.2024-01-25.at.07.19.09.mov
Screen.Recording.2024-01-25.at.07.22.00.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-01-25.at.07.33.30.mov
MacOS: Chrome / Safari
Screen.Recording.2024-01-25.at.07.38.51.mov
MacOS: Desktop
Screen.Recording.2024-01-25.at.07.27.21.mov