-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bank account shows not found when trying to pay with business bank account #35981
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@mountiny Can you confirm here one thing? Choose Pay with Expensify option and choose Business Bank Account Does this create a new workspace every time? |
@@ -1562,7 +1562,7 @@ function createWorkspaceFromIOUPayment(iouReport: Report | EmptyObject): string | |||
const policyID = generatePolicyID(); | |||
const workspaceName = generateDefaultWorkspaceName(sessionEmail); | |||
const employeeAccountID = iouReport.ownerAccountID; | |||
const employeeEmail = iouReport.ownerEmail; | |||
const employeeEmail = iouReport.ownerEmail ?? ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const employeeEmail = iouReport.ownerEmail ?? ''; | |
const employeeEmail = allPersonalDetails?.[employeeAccountID?.toString() ?? '']?.login; |
Maybe use this instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think that we don't need to have an email here, we can just put it empty and it will still work
employeeEmail = ''
but I guess it would look weird. But instead of retrieving the email from the personal detail, I just use null-coalescing to keep it simple.
I can help answer this one, yes |
For now, yes! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-18.at.12.12.16.PM.movAndroid: mWeb ChromeScreen.Recording.2024-02-18.at.11.45.22.AM.moviOS: NativeScreen.Recording.2024-02-18.at.11.57.40.AM.moviOS: mWeb SafariScreen.Recording.2024-02-18.at.11.36.04.AM.movMacOS: Chrome / SafariScreen.Recording.2024-02-18.at.11.31.05.AM.movMacOS: DesktopScreen.Recording.2024-02-18.at.11.50.42.AM.mov |
@bernhardoj I noticed a console warning on the ios native video, is that being fixed or should we open an issue for it? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.43-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀
|
Details
When choosing business bank account to pay, a bank account page should be shown instead of not found page.
Fixed Issues
$ #35366
PROPOSAL: #35366 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-02-07.at.15.31.32.mov
Android: mWeb Chrome
Screen.Recording.2024-02-07.at.15.32.22.mov
iOS: Native
Screen.Recording.2024-02-07.at.15.26.17.mov
iOS: mWeb Safari
Screen.Recording.2024-02-07.at.15.24.21.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-07.at.15.29.07.mov
MacOS: Desktop
Screen.Recording.2024-02-07.at.15.22.47.mov