-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Architecture] Upgrade react-native-safe-area-context
#36137
[New Architecture] Upgrade react-native-safe-area-context
#36137
Conversation
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-13.at.5.24.26.PM.mp4Android: mWeb ChromeScreen.Recording.2024-02-13.at.5.26.26.PM.mp4iOS: NativeScreen.Recording.2024-02-13.at.5.15.48.PM.mp4iOS: mWeb SafariScreen.Recording.2024-02-13.at.5.23.03.PM.mp4MacOS: Chrome / SafariScreen.Recording.2024-02-13.at.5.10.48.PM.mp4MacOS: DesktopScreen.Recording.2024-02-13.at.5.12.57.PM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @NikkiWines
🎀 👀 🎀
C+ Reviewed
We did not find an internal engineer to review this PR, trying to assign a random engineer to #35998 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
FYI: Melvin bot added @NikkiWines as internal reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
hi |
🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.42-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀
|
Details
Fixed Issues
$ #35998
Tests
Check if insets are working properly (they are responsible for margins / paddings around the app making sure that nothing is covered by i.e. notch on Iphones)
Offline tests
N/A
QA Steps
Check if insets are working properly (they are responsible for margins / paddings around the app making sure that nothing is covered by i.e. notch on Iphones)
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov