-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent system paid message #36298
Conversation
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@DylanDylann My native device is failing now. Please help to test on these platforms. |
On my list today |
please resolve conflict |
src/libs/ReportUtils.ts
Outdated
@@ -2296,15 +2297,18 @@ function getReportPreviewMessage( | |||
if (isSettled(report.reportID) || (report.isWaitingOnBankAccount && isPreviewMessageForParentChatReport)) { | |||
// A settled report preview message can come in three formats "paid ... elsewhere" or "paid ... with Expensify" | |||
let translatePhraseKey: TranslationPaths = 'iou.paidElsewhereWithAmount'; | |||
if ( | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dukenv0307 Bump
@@ -354,7 +354,15 @@ const ContextMenuActions: ContextMenuAction[] = [ | |||
const modifyExpenseMessage = ModifiedExpenseMessage.getForReportAction(reportID, reportAction); | |||
Clipboard.setString(modifyExpenseMessage); | |||
} else if (ReportActionsUtils.isMoneyRequestAction(reportAction)) { | |||
const displayMessage = ReportUtils.getIOUReportActionDisplayMessage(reportAction); | |||
const displayMessage = ReportUtils.getReportPreviewMessage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there are many differences between getIOUReportActionDisplayMessage
and getReportPreviewMessage
functions. Using getReportPreviewMessage
will change other behaviors (not relevant to this issue)
This is an example
Screen.Recording.2024-02-15.at.11.10.56.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DylanDylann For this case I think we should ask internal team to confirm the expected for this case again, because it's displayed Scan in progress
but the message is copied now is split $0.00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dukenv0307 Also remove getIOUReportActionDisplayMessage function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DylanDylann I updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened here? getReportPreviewMessage
retrieves the message for the report preview. We've been displaying the wrong message for IOU actions for a while, but the messages displayed by getIOUReportActionDisplayMessage
are the right ones. If that causes other bugs, we need to address them, but not revert back to the wrong messages. Was there a discussion about this on Slack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong here? I saw that all cases in getIOUReportActionDisplayMessage
already have in getReportPreviewMessage
.
@dukenv0307 Please resolve conflict |
@DylanDylann I resolved the conflict. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativea.mp4Android: mWeb Chromech.mp4iOS: Nativeios.mp4iOS: mWeb Safarisa.mp4MacOS: Chrome / Safarimes.mp4MacOS: Desktopdes.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey, what was the reason again that we're removing the actor from the system message? In the desktop screenshot, I see that the first system message has the actor but now the second one doesn't. That felt a little inconsistent to me. I see that the main issue lists that as expected behavior but I wanted to ask if that is actually the intended behavior. Also asked internally. |
@srikarparsi It's expected that we confirmed here #33819 (comment). |
Got it, thanks! Also confirmed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.43-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀
|
Details
Fixed Issues
$ #33819
PROPOSAL: #33819 (comment)
Tests
%workspaceName% paid $100.00
%payerName%: paid $100.00 [using Expensify || elsewhere]
paid $100.00 [using Expensify || elsewhere]
Offline tests
Same as above
QA Steps
%workspaceName% paid $100.00
%payerName%: paid $100.00 [using Expensify || elsewhere]
paid $100.00 [using Expensify || elsewhere]
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2024-02-21.at.11.06.13.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-02-21.at.11.01.51.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-21.at.10.55.21.mov
MacOS: Desktop
Screen.Recording.2024-02-21.at.11.12.18.mov