-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation scrolling to the beginning of the chat. #36309
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@sahilnagpal26 For your next PR, please place any extra text in the |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari36309-web.mp4MacOS: Desktop36309-desktop.mp4 |
@sahilnagpal26 You also need to sign your commits so that the checks will pass. Please follow the instructions in https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits in order to do this, then force-push to your branch and then ping me in this PR thread once that's done. Thanks. |
3bf4c34
to
85dd315
Compare
85dd315
to
a3ba909
Compare
@akinwale Updated the PR! Thanks for all the help here. |
@sahilnagpal26 You are required to test your fix on each platform and upload the videos in the corresponding sections in the OP. |
@sahilnagpal26 Following up on #36309 (comment), in this instance, since this behaviour is only happening on desktop and desktop web, you can upload videos for these. For the other platforms, you can upload a screenshot showing the app running. |
Reassigning to @neil-marcellini |
@akinwale Updated the screenshots and videos for different platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.43-0 🚀
|
I reverted this PR since it caused a couple of regressions. @sahilnagpal26 can you work on a new PR fixing those issues please? |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀
|
cc @akinwale
Details
Fixed Issues
$ #35763
PROPOSAL: #35763 (comment)
Tests
trimmed-35763.mov
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
trimmed-35763.mov
MacOS: Desktop
trimmed-desktop.mov