-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix listener in options selector #36396
[CP Staging] Fix listener in options selector #36396
Conversation
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Please fill the "Details" with the context! Link all relevant PRs. |
Actually I am fixing one issue in this PR only to keep changes to a minimum. |
That's fine. But we should also mention #34471. I'll negotiate not to include it in the penalty, but that doesn't mean we should obfuscate the PR descriptions. |
@rushatgabhane You can unassign yourself, we'll handle it |
PR incorrectly linked in "Fixed Issues" |
Corrected |
Reviewer Checklist
Screenshots/VideosAndroid: Nativefix-description-enter-android-compressed.mp4Android: mWeb Chromefix-description-enter-android-web-compressed.mp4iOS: Nativefix-description-enter-ios-compressed.mp4iOS: mWeb Safarifix-description-enter-ios-web-compressed.mp4MacOS: Chrome / Safarifix-description-enter-web-converted.mp4MacOS: Desktopfix-description-enter-desktop-converted.mp4 |
CC: @Beamanator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Prepending |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix listener in options selector (cherry picked from commit fa309dd)
🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 1.4.40-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.40-5 🚀
|
Details
The issue stems from #32464 as it creates a ghost subscribe event on the Component update, which has no way to do an unsubscribe call (This is happening due to a double call to
this.subscribeToEnterShortcut()
on update).This PR will first unsubscribe and then re-subscribe to the event to get rid of this problem.
This problem was detected with #34471.
Fixed Issues
$ #36370
$ #31433
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2024-02-13.at.3.09.47.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-02-13.at.2.54.11.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-13.at.2.51.29.PM.mov
MacOS: Desktop
Screen.Recording.2024-02-13.at.2.59.31.PM.mov