-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move violation message below billable field #36533
Move violation message below billable field #36533
Conversation
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/Videos |
@trevor-coleman I am confused by your comment
I am seeing that this PR just moved the message below View |
violations={getViolationsForField('billable')} | ||
isLast | ||
/> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you didn't push latest changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah looks like not -- they are up now.
Sorry in the original issue we talked about moving the ViolationMessages component below the containing view in the code. |
ok so this PR is in good shape right now? |
Should be good to go now. |
Just want to flag that tomorrow is my last day on the project, and I won't be available for further updates after that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.43-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀
|
@aimane-chnaif Was an issue created when you reviewed this to pay for this issue? Making sure so we can close the original one |
I don't see any. Still expecting to be paid in #36481 |
@aimane-chnaif Ok, I will create an issue for the payment then |
Details
Moves the error message below the field on billable.
To do this I:
Fixed Issues
$ #36481
Tests
Pre-requisite: as an employee of a workspace, create an expense with Billable option toggled on.
Offline tests
N/A
QA Steps
Pre-requisite: as an employee of a workspace, create an expense with Billable option toggled on.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectionproduction API to ensure there are no regressions (e.g. long loading states that impact usability).
toggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and usingthe translation method
Link to Slack message:
the localization methods
should be capitalized), and is approved by marketing by adding the
Waiting for Copy
label for a copy review on the original GH to get the correct copy.index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are workingas expected)
i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)blocks, quotes, headings, bold, strikethrough, and italic.
like
Avatar
is modified, I verified thatAvatar
is working as expected in all cases)out account.
Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Having HTTPS issues with the website on iOS, but didn't want to hold up the PR for them. I checked in desktop safari and it was fine.
MacOS: Chrome / Safari
MacOS: Desktop