-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set cursor to default when the steps are non-clickable #36573
Conversation
This one is only related to the cursor styling, therefore I did not attach recordings from mobile devices if that's OK. |
@paultsimura On the Onfido step, the prior steps should be locked and not clickable, but that is not the case from my testing. Please check this. locked-step-bug.mp4 |
@akinwale can I get access to testing Onfido acc somehow? |
@paultsimura There's no need to actually go through with the Onfido process. The flow just needs to get to the step. You can try going back to step 2 and then pressing the Next button to get to the Onfido step. |
@akinwale could you please clear your caches and double-check? And also please check if you're testing the latest branch. Even without my changes, you shouldn't have the "pointer" cursor as all the steps are disabled in the latest I have the correct cursor: |
Weird. I see the correct cursor now. Was getting the old behaviour even with new incognito browsing sessions. Thanks. |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari36573-web.mp4MacOS: Desktop36573-desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.43-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀
|
Details
Fixed Issues
$ #36506
PROPOSAL: #36506 (comment)
Tests
Same as QA
Offline tests
Same as QA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-02-15.at.13.36.52.mov
MacOS: Desktop
Screen.Recording.2024-02-15.at.13.31.50-compressed.mp4