-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: reuse uploaded baseline app for e2e perf. regression testing pipeline #36686
ci: reuse uploaded baseline app for e2e perf. regression testing pipeline #36686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good but waiting for @AndrewGable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good but waiting for @AndrewGable
@hannojg the validate github actions is failing |
It seems like this PR doesn't need c+ review? :) |
Correct, thank you! |
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
…use-main-baseline-build
Reviewer Checklist
Screenshots/VideosAndroid: NativeN/A - Tests Android: mWeb ChromeN/A - Tests iOS: NativeN/A - Tests iOS: mWeb SafariN/A - Tests MacOS: Chrome / SafariN/A - Tests MacOS: DesktopN/A - Tests |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.43-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀
|
Details
Right now the uploaded baseline app for the current active released version isn't reused between e2e test runs, but is rebuild for every run, as described in the issue.
Artifacts can only be used by their name in the same workflow run. However:
So this PR contains the following changes:
Fixed Issues
$ #36685
PROPOSAL:
Tests
Dev/CI only change, no tests needed.
Offline tests
QA Steps
Dev/CI only change, no tests needed.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Dev/CI only change, no screenshots needed.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop