Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IOU Components to /ReportActionItem folder & rename #3674

Merged
merged 7 commits into from
Jun 18, 2021

Conversation

Julesssss
Copy link
Contributor

@Julesssss Julesssss commented Jun 18, 2021

CC @tgolen -- as you suggested this change in an older PR review

Details

Simply refactors the three ReportActionItemIOU... components to a new package to simplify the naming. The components are IOUPreview, IOUAction, and IOUQuote and all relate to the Preview component -- which is what we should test.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/164356

Tests

We need to review the IOU flows to ensure the regression didn't break anything. Please do the following and raise any issues that occur:

  • Create a new IOU Request of any amount
  • Create a new Bill Split of any amount with 1 user
  • Ensure you see a preview component in the chat

Screenshot 2021-06-18 at 14 18 34

  • View Details for one of these requests and ensure you see the Preview component
  • Cancel/decline one of the transactions transaction

Screenshot 2021-06-18 at 14 16 03

  • As the receiving user, settle one of the IOU's using the 'I'll settle elsewhere' option
  • The Preview Component should show 'user PAID user' in both the View Details and chat views

Screenshot 2021-06-18 at 14 22 47

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Screenshot 2021-06-18 at 14 16 03

Web

Screenshot 2021-06-18 at 14 18 34

Mobile Web

Simulator Screen Shot - iPhone 8 - 2021-06-18 at 14 45 23

Desktop

Screenshot 2021-06-18 at 14 34 53

iOS

Simulator Screen Shot - iPhone 8 - 2021-06-18 at 14 44 26

Android

Screenshot_1623334567

@Julesssss Julesssss requested a review from a team June 18, 2021 13:46
@Julesssss Julesssss self-assigned this Jun 18, 2021
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team June 18, 2021 13:47
@Julesssss
Copy link
Contributor Author

While not that important, it would be great to get this PR merged ASAP as it touches files that are likely to have conflicts with other IOU issues.

@Julesssss Julesssss mentioned this pull request Jun 18, 2021
5 tasks
Copy link
Contributor

@HorusGoul HorusGoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HorusGoul HorusGoul merged commit 7931eea into main Jun 18, 2021
@HorusGoul HorusGoul deleted the jules-refactorIOUReportActionComponents branch June 18, 2021 15:47
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.71-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants