Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#35712 selection list refactor #37000

Merged
merged 21 commits into from
Feb 21, 2024
Merged

#35712 selection list refactor #37000

merged 21 commits into from
Feb 21, 2024

Commits on Feb 20, 2024

  1. render item prop exposed

    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    0348111 View commit details
    Browse the repository at this point in the history

  2. render item prop handled where selection list used

    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    9b44d95 View commit details
    Browse the repository at this point in the history

  3. list item definition extracted from base list item

    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    bc397c3 View commit details
    Browse the repository at this point in the history

  4. list item styling moved to specific list style elements instead of ba… 

    …se one
    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    65abacf View commit details
    Browse the repository at this point in the history

  5. base list items used by specific list elements instead coupling with … 

    …selection list
    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    1551fac View commit details
    Browse the repository at this point in the history

  6. prettier and lint fixes

    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    eba4f51 View commit details
    Browse the repository at this point in the history

  7. type mismatch fixed

    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5fdb270 View commit details
    Browse the repository at this point in the history

  8. ability to use children explicitly added

    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    277e565 View commit details
    Browse the repository at this point in the history

  9. wrapper and select multiple styles exposed outside the base list item

    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ed67986 View commit details
    Browse the repository at this point in the history

  10. prettier fixes applied

    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d64e8a1 View commit details
    Browse the repository at this point in the history

  11. switched from renderItem to ListItem prop

    @burczu
    burczu committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c4a621b View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. used correct ListItem in all the confusing places

    @burczu
    burczu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    7697efc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor/35712-selection-list-refactor

    @burczu
    burczu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9fbf025 View commit details
    Browse the repository at this point in the history

  3. selection list performance test fixed

    @burczu
    burczu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    909ae4d View commit details
    Browse the repository at this point in the history

  4. prettier fixed

    @burczu
    burczu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    66ba2dd View commit details
    Browse the repository at this point in the history

  5. unnecessary commented code removed

    @burczu
    burczu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    432a450 View commit details
    Browse the repository at this point in the history

  6. allowing only expected types as ListItem

    @burczu
    burczu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    742d5f2 View commit details
    Browse the repository at this point in the history

  7. prettier, one more time

    @burczu
    burczu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    24ff7de View commit details
    Browse the repository at this point in the history

  8. user specific props added

    @burczu
    burczu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    caeed9a View commit details
    Browse the repository at this point in the history

  9. common styles extracted to StyleUtils

    @burczu
    burczu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    01d08cd View commit details
    Browse the repository at this point in the history

  10. missing comment added

    @burczu
    burczu committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    45fd85b View commit details
    Browse the repository at this point in the history