Fixes for selection list #37521

rayane-djouah · 2024-02-29T15:55:04Z

Details

Fixed Issues

$ #37295
$ #37511
$ #37599
PROPOSAL: #37295 (comment)

Tests

Test 1:

Go to Workspace settings
Select a workspace
Go to Members
Click on Member and Role
Verify that Member and Role should are not clickable, only the checkbox is clickable.

Test 2:

Precondition: User is admin of Collect workspace that has categories.
Go to workspace settings.
Select the Collect workspace.
Click Settings.
Click Categories.
Click outside near the right side of checkbox.
Verify that the checkbox will not be clickable outside the checkbox.

Test 3:

Click on FAB > Start Chat > Room
Create a new room
Open room details
Click on Members
Verify that all members are selected when you click on "Select all" text in the right of the checkbox

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.Recording.2024-02-29.224129.mp4

Android: mWeb Chrome

mweb.chrome.Recording.2024-02-29.232036.mp4

iOS: Native

ios.mp4

Recording.2024-03-13.205646.mp4

iOS: mWeb Safari

mweb.safari.Recording.2024-02-29.230057.mp4

MacOS: Chrome / Safari

Web.Recording.2024-02-29.211032.mp4

MacOS: Desktop

Desktop.Recording.2024-02-29.214234.mp4

Recording.2024-03-13.205747.mp4

…bers in Members list

melvin-bot · 2024-02-29T19:58:56Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-djouah · 2024-02-29T23:04:43Z

PR ready for review @aimane-chnaif

rayane-djouah · 2024-03-02T00:32:21Z

Conflicts resolved

aimane-chnaif · 2024-03-03T15:46:20Z

@Expensify/design which one is better when no custom header?

Option 1. only checkbox should be clickable

Screen.Recording.2024-03-03.at.4.41.54.PM.mov

Option 2. both checkbox and title should be clickable

Screen.Recording.2024-03-03.at.4.41.17.PM.mov

When custom header shows, only checkbox is clickable (this is correct behavior)

Screen.Recording.2024-03-03.at.4.44.57.PM.mov

dubielzyk-expensify · 2024-03-03T22:55:14Z

@Expensify/design which one is better when no custom header?

I'd say title and checkbox should be clickable. So option 2.

Also just confirming that we want the checkboxes to line up as well :)

rayane-djouah · 2024-03-04T00:24:39Z

Updated

dannymcclain · 2024-03-04T14:02:59Z

I'd say title and checkbox should be clickable. So option 2.

I agree—I think that when the label is Select all it's directly related to the checkbox/select action, so it really needs to be clickable. But when it's a custom header (Members) it's not necessarily reinforcing the select all action and we probably want to reserve clicking that header for sorting and stuff.

Also just confirming that we want the checkboxes to line up as well :)

Please! 🙏

shawnborton · 2024-03-04T16:58:15Z

Yup, agree with all of that too.

aimane-chnaif · 2024-03-04T16:59:20Z

Thanks

@rayane-djouah let's fix Also just confirming that we want the checkboxes to line up as well :)

rayane-djouah · 2024-03-04T17:00:48Z

Also just confirming that we want the checkboxes to line up as well :)

addressed by 94452f5

rayane-djouah · 2024-03-06T16:13:08Z

Conflicts resolved

rayane-djouah · 2024-03-07T09:23:17Z

Friendly bump @aimane-chnaif

aimane-chnaif · 2024-03-10T14:27:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

aimane-chnaif · 2024-03-10T14:27:53Z

@rayane-djouah please merge main

rayane-djouah · 2024-03-10T15:53:39Z

Merged main @aimane-chnaif

aimane-chnaif · 2024-03-11T05:04:08Z

@rayane-djouah this is accessibility issue so maybe not a blocker but can we fix here?
As you see video, checkbox is highlighted 2 times (rectangle, rounded rectangle)
Let's make the behavior same as checkbox in each item which has only highlight of rounded rectangle

Screen.Recording.2024-03-11.at.5.01.06.AM.mov

aimane-chnaif · 2024-03-11T05:14:42Z

@rayane-djouah didn't you retest your latest changes on all platforms?
Test 3 is failing

BUG on iOS:

aimane-chnaif · 2024-03-12T14:53:00Z

@rayane-djouah bump

rayane-djouah · 2024-03-13T13:50:31Z

Sorry for the delay, I will update today.

rayane-djouah · 2024-03-13T20:01:07Z

Updated
@aimane-chnaif

rayane-djouah · 2024-03-15T17:30:46Z

@aimane-chnaif Bump

aimane-chnaif · 2024-03-18T01:37:28Z

There are 2 concerns that might be considered as expected (at least not blocker):

"Select all" text is highlighted on Tab key press
Not entire row but only checkbox and "Select all" are clickable

Screen.Recording.2024-03-18.at.1.34.28.AM.mov

bondydaa

Not entire row but only checkbox and "Select all" are clickable

I think this is ok per the previous comments from design, right?

melvin-bot · 2024-03-20T16:23:27Z

@bondydaa looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

aimane-chnaif · 2024-03-20T16:24:38Z

Not entire row but only checkbox and "Select all" are clickable

I think this is ok per the previous comments from design, right?

Right.
Actually, entire row click behavior was not mentioned.
But I believe it's expected that blank space should not be clickable area.

OSBotify · 2024-03-20T16:29:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-22T16:19:48Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-27T04:48:57Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rayane-djouah added 3 commits February 29, 2024 16:54

Fix: Workspace - Member and Role can be clicked to select all the mem…

1512c35

…bers in Members list

Merge branch 'main' into fix/37295

8528ef6

Fix: Category - Checkbox is clickable outside near the right of checkbox

c420550

rayane-djouah changed the title ~~Fix: Workspace - Member and Role can be clicked to select all the mem…~~ Fixes for multi selections Feb 29, 2024

rayane-djouah changed the title ~~Fixes for multi selections~~ Fixes for selection list Feb 29, 2024

Merge branch 'Expensify:main' into fix/37295

61fc1f5

rayane-djouah marked this pull request as ready for review February 29, 2024 19:58

rayane-djouah requested a review from a team as a code owner February 29, 2024 19:58

melvin-bot bot requested review from aimane-chnaif and removed request for a team February 29, 2024 19:58

Merge branch 'Expensify:main' into fix/37295

2e64a56

rayane-djouah mentioned this pull request Mar 2, 2024

[HOLD for payment 2024-04-03] [$500] Web -Workspace-Highlight for the checkbox goes out of bound on members page #37599

Closed

6 tasks

Merge branch 'main' into fix/37295

cb90dbf

line up checkboxes

94452f5

Merge branch 'main' into fix/37295

a1ad38a

Merge branch 'Expensify:main' into fix/37295

5c62b37

Merge branch 'Expensify:main' into fix/37295

885e8db

aimane-chnaif mentioned this pull request Mar 13, 2024

[HOLD for payment 2024-05-15] HIGH: [Polish] [$500] Redesign thread ancestry #36752

Closed

rayane-djouah added 3 commits March 13, 2024 20:06

fix Expensify#37521

7431057

Merge branch 'main' into fix/37295

491d70d

fix Expensify#37521

6690997

aimane-chnaif approved these changes Mar 18, 2024

View reviewed changes

melvin-bot bot requested a review from bondydaa March 18, 2024 02:03

bondydaa approved these changes Mar 20, 2024

View reviewed changes

bondydaa merged commit 99169e1 into Expensify:main Mar 20, 2024
17 checks passed

melvin-bot bot added the Emergency label Mar 20, 2024

rayane-djouah deleted the fix/37295 branch March 21, 2024 23:12

github-actions bot mentioned this pull request Mar 22, 2024

Deploy Checklist: New Expensify 2024-03-22 #38811

Closed

This was referenced Mar 27, 2024

[HOLD for payment 2024-04-03] [$500] Workspace - Member and Role can be clicked to select all the members in Members list #37295

Closed

[HOLD for payment 2024-04-03] Category - Checkbox is clickable outside near the right of checkbox #37511

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for selection list #37521

Fixes for selection list #37521

rayane-djouah commented Feb 29, 2024 •

edited

Loading

melvin-bot bot commented Feb 29, 2024

rayane-djouah commented Feb 29, 2024

rayane-djouah commented Mar 2, 2024

aimane-chnaif commented Mar 3, 2024

dubielzyk-expensify commented Mar 3, 2024

rayane-djouah commented Mar 4, 2024

dannymcclain commented Mar 4, 2024

shawnborton commented Mar 4, 2024

aimane-chnaif commented Mar 4, 2024

rayane-djouah commented Mar 4, 2024

rayane-djouah commented Mar 6, 2024

rayane-djouah commented Mar 7, 2024

aimane-chnaif commented Mar 10, 2024 •

edited

Loading

aimane-chnaif commented Mar 10, 2024

rayane-djouah commented Mar 10, 2024

aimane-chnaif commented Mar 11, 2024

aimane-chnaif commented Mar 11, 2024 •

edited

Loading

aimane-chnaif commented Mar 12, 2024

rayane-djouah commented Mar 13, 2024

rayane-djouah commented Mar 13, 2024

rayane-djouah commented Mar 15, 2024

aimane-chnaif commented Mar 18, 2024

bondydaa left a comment

melvin-bot bot commented Mar 20, 2024

aimane-chnaif commented Mar 20, 2024

OSBotify commented Mar 20, 2024

OSBotify commented Mar 22, 2024

OSBotify commented Mar 27, 2024

Fixes for selection list #37521

Fixes for selection list #37521

Conversation

rayane-djouah commented Feb 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 29, 2024

rayane-djouah commented Feb 29, 2024

rayane-djouah commented Mar 2, 2024

aimane-chnaif commented Mar 3, 2024

dubielzyk-expensify commented Mar 3, 2024

rayane-djouah commented Mar 4, 2024

dannymcclain commented Mar 4, 2024

shawnborton commented Mar 4, 2024

aimane-chnaif commented Mar 4, 2024

rayane-djouah commented Mar 4, 2024

rayane-djouah commented Mar 6, 2024

rayane-djouah commented Mar 7, 2024

aimane-chnaif commented Mar 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

aimane-chnaif commented Mar 10, 2024

rayane-djouah commented Mar 10, 2024

aimane-chnaif commented Mar 11, 2024

aimane-chnaif commented Mar 11, 2024 • edited Loading

aimane-chnaif commented Mar 12, 2024

rayane-djouah commented Mar 13, 2024

rayane-djouah commented Mar 13, 2024

rayane-djouah commented Mar 15, 2024

aimane-chnaif commented Mar 18, 2024

bondydaa left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 20, 2024

aimane-chnaif commented Mar 20, 2024

OSBotify commented Mar 20, 2024

OSBotify commented Mar 22, 2024

OSBotify commented Mar 27, 2024

rayane-djouah commented Feb 29, 2024 •

edited

Loading

aimane-chnaif commented Mar 10, 2024 •

edited

Loading

aimane-chnaif commented Mar 11, 2024 •

edited

Loading