-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply custom scrollview throughout the app #37727
Conversation
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid4.webmAndroid: mWeb Chromeandroid3.webmiOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-06.at.19.36.46.mp4Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-06.at.19.34.21.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-06.at.19.42.17.mp4MacOS: Chrome / SafariScreen.Recording.2024-03-06.at.19.26.10.movMacOS: DesktopScreen.Recording.2024-03-06.at.19.44.13.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
The code changes make sense to me. Since this PR touches several components can we also test more pages? |
Lots of pages have scroll view so kind of full regression test is needed. I already did basic testing scroll behavior on various pages. |
I also did basic testing for the scrollbar by going back and forth to various pages. @MariaHCD do you want me to add more screencasts considering some other pages too? |
If you've both done testing on various pages, then I think we should be fine. However, can we update the test steps to be more detailed? |
updated |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.4.49-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
Details
introduceshouldAddRightInsetForIndicator
prop with default value = truescrollIndicatorInsets
is set, it's more priorityand ignoresshouldAddRightInsetForIndicator
Fixed Issues
$ #36677
PROPOSAL: #36677 (comment)
Tests
Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
mchrome.mov
iOS: Native
ios.mov
iOS: mWeb Safari
msafari.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov