-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Investigate App Crash MainActivity.onCreate #37812
Conversation
@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Assigning this over to @akinwale as the C+ so he can test it, then it should go to @marcaaron for final review. |
@neil-marcellini Already tested this. The previous PR was accidentally closed. |
@akinwale @marcaaron Hello. |
@@ -44,6 +44,9 @@ allprojects { | |||
force "com.facebook.react:react-native:" + REACT_NATIVE_VERSION | |||
force "com.facebook.react:hermes-engine:" + REACT_NATIVE_VERSION | |||
|
|||
//Fix Investigate App Crash MainActivity.onCreate #35655 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//Fix Investigate App Crash MainActivity.onCreate #35655 | |
// For more context https://github.com/Expensify/App/issues/35655 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can move ahead if @akinwale tested it. I can still see the crash happening in firebase
@akinwale can you add a reviewer checklist to this PR? |
@yoyumiracle regarding upwork account, I am not sure, we do not really deal with it, contributors handle that themselves. If you can provide some upwork profile for payment we can pay it there once completed |
@mountiny Hi. |
Cool waiting for the checklist from @akinwale |
Reviewer Checklist
Screenshots/VideosAndroid: Native36465-android-browserstack.mp4Android: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@marcaaron |
Going to merge and updated the test steps in staging |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Deployed to staging, we will monitor now if this crash still occurs in the latest staging version |
@yoyumiracle This was deployed in the latest 1.4.50 staging deploy but the crash still seems to be occurring
|
Any other logs? |
Let me see |
And
And
and
and
and
|
Then we can use so loader version 11.0+ instead of 10.4+. |
@mountiny Hi. |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
I fixed the bug related on crash log.
Details
Fixed Issues
$ #35655
PROPOSAL: #35655 (comment)
Tests
Offline tests
N/A
QA Steps
Once in staging, monitor the firebase Android crashes to make sure the
MainActivity.onCreate
is not present anymore on the OnePlus 8 ProPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
It doesn't need any Screenshot/Videos.