-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Performance and heat issues on the 'Troubleshoot' page #38093
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1cb4eaa
Performance and heat issues on the 'Troubleshoot' option
ikevin127 365903d
removed isFocused
ikevin127 7227b01
Merge branch 'main' of https://github.com/Expensify/App into fix/36645
ikevin127 fa6db6b
Merge branch 'main' of https://github.com/Expensify/App into fix/36645
ikevin127 f690971
added types.ts file
ikevin127 c512812
added return AppStateType to useAppState web implementation
ikevin127 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import React from 'react'; | ||
import type {AppStateStatus} from 'react-native'; | ||
import {AppState} from 'react-native'; | ||
|
||
type AppStateType = { | ||
isForeground: boolean; | ||
isInactive: boolean; | ||
isBackground: boolean; | ||
}; | ||
|
||
function useAppState() { | ||
const [appState, setAppState] = React.useState<AppStateType>({ | ||
isForeground: AppState.currentState === 'active', | ||
isInactive: AppState.currentState === 'inactive', | ||
isBackground: AppState.currentState === 'background', | ||
}); | ||
|
||
React.useEffect(() => { | ||
function handleAppStateChange(nextAppState: AppStateStatus) { | ||
setAppState({ | ||
isForeground: nextAppState === 'active', | ||
isInactive: nextAppState === 'inactive', | ||
isBackground: nextAppState === 'background', | ||
}); | ||
} | ||
const subscription = AppState.addEventListener('change', handleAppStateChange); | ||
return () => subscription.remove(); | ||
}, []); | ||
|
||
return appState; | ||
} | ||
|
||
export default useAppState; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
export default function useAppState() { | ||
// Since there's no AppState in web, we'll always return isForeground as true | ||
return {isForeground: true, isInactive: false, isBackground: false}; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @ikevin127 I think we need to remove
isFocus
. Otherwise, in Web the Lottie animation of About page is hidden when we open Troubleshoot pageThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoangzinh Good catch, removed it.
From my tests I could not see any difference in performance with the additional
!isFocused
, so removing it does not affect the performance of the proposed fix any way 👍