-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Misaligned vertical metrics ExpensifyNewKansas
font on OS/2
#38116
Conversation
@dannymcclain @ntdiary One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
@dannymcclain Hope this helps!
|
Adding @shawnborton too but I think this is looking good! |
Nice! Looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, forgot to add my actual review part when adding Shawn 😅
Reviewer Checklist
Screenshots/VideosAndroid: Native38116-android-native.mp4Android: mWeb Chrome38116-android-chrome.mp4iOS: Native38116-ios-native.mp4iOS: mWeb Safari38116-ios-safari.mp4MacOS: Chrome / Safari38116-web.mp4MacOS: Desktop38116-desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. :)
@chiragsalian Opps the checklist checks are failing. Can you take a look? |
what checklist checks are you referring to? Can you link it? |
🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.52-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.52-6 🚀
|
Details
ExpensifyNewKansas
has misaligned vertical metrics on OS/2 as measured here. This PR replaced the correct font from font foundry.Fixed Issues
$ #35435
PROPOSAL: #35435 (comment)
Tests
ExpensifyNewKansas
fonts underassets/fonts/web
in https://vertical-metrics.netlify.app/Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop