-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/37732: Error is not cleared after coming back to Connect manually empty form. #38148
Fix/37732: Error is not cleared after coming back to Connect manually empty form. #38148
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@allroundexperts I will review this |
All yours @s77rt |
@Swor71 or @roryabraham Update step |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemweb-chrome.moviOS: Nativeios.moviOS: mWeb Safarimweb-safari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #37732 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
@s77rt hey, any chance we could move forward with this and get it merged? thanks! |
@roryabraham will review this shortly |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.56-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀
|
Details
This PR adds
hideBankAccountErrors
tohandleBackButtonPress
inBankInfo
in order to remove persisting errors when exiting the flow.Fixed Issues
$ #37732
PROPOSAL:
Tests
Offline tests
QA Steps
Go to Workspace > Bank account.
Tap on Connect manually.
Enter "011401533" as the Routing number.
Enter "0000" as the Account number.
Tap on Next then on Confirm
Verify you are taken back to the form and an error is displayed.
Tap on the back arrow.
Tap on Connect manually.
Verify that the error is not displayed.
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-03-12.at.16.34.04.mov
MacOS: Desktop