Deprecate POLICY_MEMBERS #39489
Deprecate POLICY_MEMBERS #39489
Conversation
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
…hanges from WorkspaceMembersPage
|
@eVoloshchak @luacmartins But before filling out the checklist, I would like to fix one bug that creates problems with displaying elements @luacmartins
|
|
Looking! |
|
I raised an internal PR to fix that issue. @ZhenjaHorbach did you see the incorrect shape being returned in any other API endpoints? |
luacmartins
changed the title
For all the time I tested |
|
Sounds good, thanks for confirming! That PR should be deployed in the next couple of days. @eVoloshchak we can continue reviewing this one and treat that as NAB for now. |
Although if we compare POLICY_MEMBERS and POLICY But this is a small problem) |
src/pages/workspace/members/WorkspaceMemberDetailsRoleSelectionPage.tsx
Outdated
Show resolved
Hide resolved
tests/actions/PolicyTest.ts
Outdated
| const policyMembers: OnyxEntry<PolicyMembers> = await new Promise((resolve) => { | ||
| const connectionID = Onyx.connect({ | ||
| key: `${ONYXKEYS.COLLECTION.POLICY_MEMBERS}${policyID}`, | ||
| callback: (members) => { | ||
| Onyx.disconnect(connectionID); | ||
| resolve(members); | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| // check if the user was added as an admin to the policy | ||
| expect(policyMembers?.[ESH_ACCOUNT_ID]?.role).toBe(CONST.POLICY.ROLE.ADMIN); | ||
|
|
There was a problem hiding this comment.
You may need to check for policyEmployeeList.
There was a problem hiding this comment.
Good catch )
I forgot about this test
I will update it this weekend
|
👋 We have conflicts here! @ZhenjaHorbach can you address them today, please? Thanks! |
Hello ) |
@trjExpensify |
|
I looked at what was done here, looks great overall, thanks a lot for taking the time to clean this up and improve it! 👍 |
|
Web-E PR is in staging. We can merge this after today's web deploy |
|
FYI, conflicts |
luacmartins
changed the title
|
Web-E is in prod. Removing hold and merging. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.63-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀
|
| value: { | ||
| [sessionAccountID]: null, | ||
| pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE, |
There was a problem hiding this comment.
we should had cleared the policy data after successfully leaving a workspace and not put the pendingAction to delete. This change caused #43436
Details
Fixed Issues
$ #39376
PROPOSAL: #39376 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_53PpKTmv.mp4
Android: mWeb Chrome
android_53PpKTmv.mp4
iOS: Native
screen-recording-2024-04-10-at-095336_HZtOZKoD.mp4
iOS: mWeb Safari
ios-web_u4b22UV5.mp4
MacOS: Chrome / Safari
web_4GP3iVyI.mp4
MacOS: Desktop
desktop_LGtQ0qQS.mp4