-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix]: Fix crash on Expense Report Title due to mismatch of reportKey
on the FE
and BE
#40704
Conversation
Signed-off-by: GandalfGwaihir <whogandalf@gmail.com>
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-04-23.at.11.37.16.AM.movAndroid: mWeb ChromeScreen.Recording.2024-04-23.at.11.38.11.AM.moviOS: NativeScreen.Recording.2024-04-23.at.11.21.38.AM.moviOS: mWeb SafariScreen.Recording.2024-04-23.at.11.22.54.AM.movMacOS: Chrome / SafariScreen.Recording.2024-04-23.at.10.37.54.AM.movMacOS: DesktopScreen.Recording.2024-04-23.at.1.29.04.PM.mov |
Co-authored-by: ahmedGaber93 <41129870+ahmedGaber93@users.noreply.github.com>
Co-authored-by: ahmedGaber93 <41129870+ahmedGaber93@users.noreply.github.com>
@GandalfGwaihir just small changes in PR description.
|
All set @ahmedGaber93 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.66-0 🚀
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.66-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀
|
Details
Currently we used to get a not found page if we accessed the title of any report view, This PR fixed the crash by not adding extra text to the text title field.
Fixed Issues
$ #40464
PROPOSAL: #40464 (comment)
Tests
Same as "QA Steps"
Offline tests
Same as "QA Steps"
QA Steps
Preconditions:
Expected result: Title edit page should open
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2024-04-22.at.8.41.23.PM.mov
MacOS: Desktop
Screen.Recording.2024-04-22.at.8.44.27.PM.mov
Android: Native
Screen.Recording.2024-04-22.at.8.54.49.PM.mov
Android: mWeb Chrome
Screen.Recording.2024-04-24.at.5.00.57.AM.mov
iOS: Native
Screen.Recording.2024-04-22.at.8.57.12.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-04-22.at.8.46.15.PM.mov