-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Search v1] Search page scroll is not smooth #42170
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0e407f2
fix: [Search v1] Search page scroll is not smooth; merge from main
charles-liang a03843a
fix: [Search v1] Search page scroll is not smooth; move type definati…
charles-liang e4f3620
fix: [Search v1] Search page scroll is not smooth; merge and resolve …
charles-liang 521e658
fix: [Search v1] Search page scroll is not smooth; use arrow callback…
charles-liang 7537123
fix: [Search v1] Search page scroll is not smooth; remove Memo Prefix…
charles-liang d0b4a9f
fix: [Search v1] Search page scroll is not smooth; add eh2077 suggestion
charles-liang 50ecf11
fix: [Search v1] Search page scroll is not smooth; add eh2077 suggestion
charles-liang 6034aee
Merge remote-tracking branch 'origin'
charles-liang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the rationale for choosing these values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
windowSize
is set to 111 because each page can contain a maximum of 500 items, and this size is sufficiently large to ensure that the entire page will not be recycled.The choice of 200 for
updateCellsBatchingPeriod
is because 200ms out of 1000ms allows it to be slightly larger, preventing continuous loading while not causing too much delay.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use different values for desktop and mobile devices? As their screens size are different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recycling of cells is only necessary in cases such as phones with low memory. I tested in iPhone 14 pro is very smooth and not need recycling.
why I set it to 111. This size ensures that in both portrait mode and landscape mode, is large enough not to be recycled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we leave a comment explaining that please?