-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stale personal details while creating task with new user #43059
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Bump @allroundexperts |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-06-10.at.2.38.51.AM.movAndroid: mWeb ChromeScreen.Recording.2024-06-10.at.2.37.45.AM.moviOS: NativeScreen.Recording.2024-06-10.at.2.36.13.AM.moviOS: mWeb SafariScreen.Recording.2024-06-10.at.2.35.17.AM.movMacOS: Chrome / SafariScreen.Recording.2024-06-10.at.2.29.35.AM.movMacOS: DesktopScreen.Recording.2024-06-10.at.2.32.42.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀
|
Details
When assigning task to accounts we haven't chat before, we generate optimistic personal details for them. Later the BE will respond with different account IDs and details but we do not clear the optimistic ones leading to stale data in Onyx. This PR fixes that.
Action Performed:
Expected Result: Account details show
Hidden
because the account ID in URL is staleActual Result: Account details show the correct assignee email but different avatar with report header
Screenshots
MacOS: Chrome / Safari
Screen.Recording.2024-06-05.at.02.21.03-compressed.mov
Fixed Issues
$ #42027
PROPOSAL: #42027 (comment)
Tests
Hidden
Offline tests
NA
QA Steps
Hidden
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
video_2024-06-05_02-34-21.mp4
iOS: Native
Screen.Recording.2024-06-05.at.02.30.16-compressed.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-06-05.at.02.24.48-compressed.mov
MacOS: Desktop